Bug 1393338

Summary: Rebalance should skip the file if the file has hardlinks instead of failing
Product: [Community] GlusterFS Reporter: Susant Kumar Palai <spalai>
Component: distributeAssignee: Susant Kumar Palai <spalai>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, nbalacha, rhs-bugs, spalai, storage-qa-internal, tdesala
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.11.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1392905 Environment:
Last Closed: 2017-05-30 18:35:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1392905    
Bug Blocks:    

Comment 1 Worker Ant 2016-11-09 11:12:06 UTC
REVIEW: http://review.gluster.org/15810 (dht/rebalance: update op_errno for rebalance failures) posted (#1) for review on master by Susant Palai (spalai)

Comment 2 Worker Ant 2016-11-14 07:05:24 UTC
REVIEW: http://review.gluster.org/15810 (dht/rebalance: update op_errno for rebalance failures) posted (#2) for review on master by Susant Palai (spalai)

Comment 3 Worker Ant 2017-03-06 06:06:36 UTC
REVIEW: https://review.gluster.org/15810 (dht/rebalance: update op_errno for rebalance failures) posted (#3) for review on master by Susant Palai (spalai)

Comment 4 Worker Ant 2017-03-06 11:42:25 UTC
REVIEW: https://review.gluster.org/15810 (dht/rebalance: update op_errno for rebalance failures) posted (#4) for review on master by Susant Palai (spalai)

Comment 5 Worker Ant 2017-03-07 05:27:18 UTC
REVIEW: https://review.gluster.org/15810 (dht/rebalance: update op_errno for rebalance failures) posted (#5) for review on master by Susant Palai (spalai)

Comment 6 Worker Ant 2017-03-07 05:44:23 UTC
REVIEW: https://review.gluster.org/15810 (dht/rebalance: update op_errno for rebalance failures) posted (#6) for review on master by Susant Palai (spalai)

Comment 7 Worker Ant 2017-03-10 04:56:23 UTC
COMMIT: https://review.gluster.org/15810 committed in master by Raghavendra G (rgowdapp) 
------
commit 64442122958011a3e7e73c5d205f37ac0da46736
Author: Susant Palai <spalai>
Date:   Wed Nov 9 16:39:44 2016 +0530

    dht/rebalance: update op_errno for rebalance failures
    
    function "rebalance_task_completion" did not honor returned values other
    than -1 and 1. This led to ignoring errno e.g in the current bug,
    ENOTSUP returned by __is_file_migratable and it returned
    EINVAL(op_errno initialized) to it's caller leading to failure messages
    logged in ERROR level.
    
    Change-Id: I45549fba35c72b278539269b750768fd89e0faf2
    BUG: 1393338
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: https://review.gluster.org/15810
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Raghavendra G <rgowdapp>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 8 Shyamsundar 2017-05-30 18:35:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/