Bug 1393482

Summary: python-jira: Provide a Python 3 subpackage
Product: [Fedora] Fedora Reporter: Iryna Shcherbina <ishcherb>
Component: python-jiraAssignee: Ralph Bean <rbean>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ishcherb, rbean, torsava
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-jira-1.0.7-1.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-17 20:51:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1285816, 1312032    
Attachments:
Description Flags
Patch to provide Python 3 subpackage
none
Patch to provide Python 3 subpackage none

Description Iryna Shcherbina 2016-11-09 16:23:46 UTC 
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's OK to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 25 as well.


If you need more instructions, a guide for porting Python-based RPMs is
available at [2].
If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
[2] http://python-rpm-porting.readthedocs.io/
Comment 1 Iryna Shcherbina 2016-11-21 12:45:29 UTC 
Created attachment 1222381 [details]
Patch to provide Python 3 subpackage

Hi Ralph,

Please find the change needed to update to the latest version and add Python 3 subpackage attached. Could you please review it and do the update?

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16552713
Comment 2 Tomas Orsava 2016-11-21 13:15:58 UTC 
Hi Iryna!

I have taken a look and here are a few notes I think might be useful:

- I would omit the `-f` flag from the `ln` commands, as if that fails it indicates something went wrong and should be fixed.

- The new sed line:
   sed -i -e '/^#!\//, 1d' %{modname}/{client,config,jirashell}.py 
  removes shebangs at all lines, not just the first (tested to be sure)

- When you're updating the version of the software in the patch, it is appreciated if you do `fedpkg new-sources` to load the new tarball into the look-aside cache and then include the change to the `sources` file in the patch, so the maintainer doesn't have to.
Comment 3 Iryna Shcherbina 2016-11-21 14:47:34 UTC 
Created attachment 1222417 [details]
Patch to provide Python 3 subpackage

Hi Tomas,

thank you for reviewing the patch!
I have addressed your comments and you may find the new version of the patch in attachments.

> - When you're updating the version of the software in the patch, it is
> appreciated if you do `fedpkg new-sources` to load the new tarball into the 
> look-aside cache and then include the change to the `sources` file in the 
> patch, so the maintainer doesn't have to.

Unfortunately, I will not be able to update the `sources`, as I am not in the packager group.

New koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16553941
Comment 4 Tomas Orsava 2016-11-21 14:52:10 UTC 
(In reply to Iryna Shcherbina from comment #3)
> Created attachment 1222417 [details]
> Patch to provide Python 3 subpackage
> 
> Hi Tomas,
> 
> thank you for reviewing the patch!
> I have addressed your comments and you may find the new version of the patch
> in attachments.
> 
> > - When you're updating the version of the software in the patch, it is
> > appreciated if you do `fedpkg new-sources` to load the new tarball into the 
> > look-aside cache and then include the change to the `sources` file in the 
> > patch, so the maintainer doesn't have to.
> 
> Unfortunately, I will not be able to update the `sources`, as I am not in
> the packager group.
> 
> New koji scratch build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=16553941

Thank you for the changes Iryna, LGTM!
Comment 5 Fedora Update System 2017-02-09 14:27:36 UTC 
python-jira-1.0.7-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-79e30bc4ea
Comment 6 Fedora Update System 2017-02-09 22:22:18 UTC 
python-jira-1.0.7-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-79e30bc4ea
Comment 7 Fedora Update System 2017-02-17 20:51:45 UTC 
python-jira-1.0.7-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.