Bug 1393547

Summary: [RFE] Unknown operating system for AWS instances
Product: Red Hat CloudForms Management Engine Reporter: David La Motta <dlamotta>
Component: ProvidersAssignee: Ladislav Smola <lsmola>
Status: CLOSED CURRENTRELEASE QA Contact: Matouš Mojžíš <mmojzis>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7.0CC: agrare, cpelland, dajohnso, dclarizi, ealcaniz, jfrey, jhardy, jocarter, lsmola, mmojzis, obarenbo, simaishi
Target Milestone: GAKeywords: FutureFeature, TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ec2:vm
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1397151 1404752 (view as bug list) Environment:
Last Closed: 2017-06-12 16:59:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: AWS Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1397151, 1404752    

Comment 2 Ladislav Smola 2016-11-16 13:29:35 UTC 
Fixed by:
https://github.com/ManageIQ/manageiq/pull/12677
https://github.com/ManageIQ/manageiq-providers-amazon/pull/84

Note: operating system is inferred from Image location, so Image needs to be refreshed and it needs to contain the OS name. Works well for AWS Public images

For more details about OS, we will need the SSA to work.
Comment 3 CFME Bot 2016-11-16 15:51:17 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/7bd7e324b4ea940962bd9037ef9e25c38797449f

commit 7bd7e324b4ea940962bd9037ef9e25c38797449f
Author:     Ladislav Smola <lsmola>
AuthorDate: Wed Nov 16 14:11:47 2016 +0100
Commit:     Ladislav Smola <lsmola>
CommitDate: Wed Nov 16 14:19:44 2016 +0100

    Show correct textual operation system name
    
    Even without operation_system relation, we can show the
    operation system, using os_image_name, which uses guest_os
    among others.
    
    os_image_name is also used for quadicon OS image, so this
    becomes more consistent
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1393547

 app/helpers/textual_mixins/textual_os_info.rb | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
Comment 4 CFME Bot 2016-11-18 17:22:43 UTC 
New commit detected on ManageIQ/manageiq-providers-amazon/master:
https://github.com/ManageIQ/manageiq-providers-amazon/commit/8424752f464cb2691775cb457457b2d39c608403

commit 8424752f464cb2691775cb457457b2d39c608403
Author:     Ladislav Smola <lsmola>
AuthorDate: Wed Nov 16 11:57:42 2016 +0100
Commit:     Ladislav Smola <lsmola>
CommitDate: Wed Nov 16 11:59:19 2016 +0100

    Fill guest_os correctly
    
    Fill guest_os correctly, inferring it from Image location
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1393547

 .../manageiq/providers/amazon/cloud_manager/refresh_parser.rb       | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 7 Satoe Imaishi 2016-12-14 14:52:02 UTC 
*** Bug 1396264 has been marked as a duplicate of this bug. ***
Comment 11 Matouš Mojžíš 2017-03-14 22:31:25 UTC 
I just deployed official RHEL 7.3 distro in AWS console and OS in CFME is displayed as unknown.
It should work even for this official distro, right?
Comment 12 Ladislav Smola 2017-03-15 08:25:17 UTC 
Matous, you need to make sure that the image is being fetched. If this is a public image, you need to have in the settings: :get_public_images: true, under :ec2.

At best, you should then use :public_images_filters, to fetch only images that are of the interest, otherwise it will collect a big amount of them (80k)
Comment 13 Matouš Mojžíš 2017-04-14 15:50:32 UTC 
Verified in 5.8.0.10. I could see OS for instance after fetching public images.