Bug 1393549

Miloslav, can you include the output of 'oc version' ? 

Also, if instead of:
oc new-app nenadalm/warehouse~https://github.com/nenadalm/Warehouse.git

You run:
oc new-app nenadalm/warehouse~https://github.com/nenadalm/Warehouse.git --name=warehouse2

Does that resolve the issue? It seems that the same ImageStream is getting used for input and output. So a new tag will kick off a build which will create a new tag and so on.

Thanks. That solved the issue (should be fixed anyway probably somehow - either by generating different name or by showing some error).

$ oc version
oc v1.3.0
kubernetes v1.3.0+52492b4
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://api.preview.openshift.com:443
openshift v3.3.1.3
kubernetes v1.3.0+52492b4

Thanks. Yes, we should detect the cycle and generate a different name or at least warn you.

I swear we have logic that's supposed to do that already, but perhaps there are cases it's not catching.

apparently we do it for new-build but not for new-app:

$ oc new-build nenadalm/warehouse~https://github.com/nenadalm/Warehouse.git
--> Found Docker image 61b5e8b (2 days old) from Docker Hub for "nenadalm/warehouse"

    * An image stream will be created as "warehouse:latest" that will track the source image
    * A source build using source code from https://github.com/nenadalm/Warehouse.git will be created
      * The resulting image will be pushed to image stream "warehouse:latest"
      * Every time "warehouse:latest" changes a new build will be triggered

error: output image of "nenadalm/warehouse:latest" should be different than input, set a different tag with --to

The comment here:  https://github.com/openshift/origin/blob/master/pkg/generate/app/cmd/newapp.go#L696

would imply the new-build vs. new-app distinction is intentional.

A search on `ExpectToBuild` seems to confirm that.  It is only set to true here:  https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/newbuild.go#L102

It stems from commit 79a03113 from back in March.  The PR is https://github.com/openshift/origin/pull/7936 and the associated issue is https://github.com/openshift/origin/issues/7718

There's this comment wrt the rationale:  https://github.com/openshift/origin/pull/7936#r55853107

At this point, do we not care about the warning vs. error distinction, and just remove the ExpectToBuild check?  Or just use ExpectToBuild to alter the use of fmt.Errorf vs. fmt.Printf("WARNING ...") ?

Thanks for digging up the history, Gabe.

I'm not sure the history clears up for me *why* we intentionally only did it for new-app.  It looks like it had to do w/ us having a "--to" flag for new-build and not for new-app, but given that you can use --name to avoid this problem with new-app, it seems like we ought to be catching it and reporting it just like we do for new-build.

I guess it also had to do w/ the fact that when new-app is instantiating a template, we should not care if you defined a cycle in your template (that's your problem at that point) though a warning would be nice.

So in sum, for new-app:

1) we need to make sure when we detect a cycle, it really is a cycle (the issue with https://github.com/openshift/origin/issues/7718 is that what it thought was a cycle was in fact *not* a cycle, it thought two things were equivalent that are not equivalent)

2) if we're instantiating a template, we can only warn you that there is a cycle, we can't error out.

3) if we're not instantiating a template, we can tell you to use --name to avoid creating a cycle. (equivalent to the --to that we recommend for new-build).

PR https://github.com/openshift/origin/pull/12104 has been submitted to fix this issue.

As an aside, when I run 

   oc new-app nenadalm/warehouse~https://github.com/nenadalm/Warehouse.git

I now get

   error: output image of "nenadalm/warehouse:latest" should be different than input, override artifact names with --name

Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/4c9330566770ff5f96745eade6bc44d99944a72d
new-app: appropriately warn/error on circular builds

Bug 1393549
Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1393549
Detailed explanation
Citing of cirular builds were performed for new-build but not new-app;
With new-app, if template, simply warn, if not template fail command

With the fix merged upstream, and given this was opened from online usage, per the process, moving the bug to modified for the productization team's attention.

I don't know if 3.5 releases have been spun yet.  That's a question for Troy.

If you can see that the fix for this is in ose/master, then yes, rpms and images have been created for this.  This is in OCP v3.5.0.8 or newer.

OK - thanks Ben and Troy.

Moving to on qa then.

Test in openshift v3.5.0.16+a26133a

@Gabe
Input image name is same with output name but different tag， will show error to create is. If should this issue be fixed.

#oc  new-app  ruby-ex:2.0 https://github.com/openshift/ruby-ex.git
--> Creating resources ...
    error: imagestreams "ruby-ex" already exists


input/output image is totally same,
'oc new-app' will prompt：
error: output image of "**" should be different than input, override artifact names with --name
‘oc new-build’ will prompt:
error: output image of "***" should be different than input, set a different tag with --to

please open a low severity bug, new-app should tolerate the existing imagestream since it's just going to create a new tag within that imagestream.

Open another low bug https://bugzilla.redhat.com/show_bug.cgi?id=1419801
Verified this bug as comment #14