Bug 1393561

Summary: Fix for bz 1389284 breaks migrations
Product: Red Hat OpenStack Reporter: Artom Lifshitz <alifshit>
Component: openstack-novaAssignee: Artom Lifshitz <alifshit>
Status: CLOSED ERRATA QA Contact: Gabriel Szasz <gszasz>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0 (Mitaka)CC: alifshit, berrange, bschmaus, dasmith, eglynn, fbaudin, gkeegan, kchamart, mpryc, sbauza, sferdjao, sgordon, srevivo, vromanso
Target Milestone: asyncKeywords: Triaged, ZStream
Target Release: 9.0 (Mitaka)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-nova-13.1.2-8.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-21 16:38:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Artom Lifshitz 2016-11-09 21:06:02 UTC 
Description of problem:

Based on code analysis and reports [1] from a customer deployment (in testing, thankfully), the fix [2] for bz 1389284 breaks migrations, perhaps only limited to migrations of VMs with SRIOV cards passed through.

Version-Release number of selected component (if applicable):

openstack-nova-13.1.2-6.el7ost

How reproducible:

Always, presumably.

Steps to Reproduce:
1. Attempt to cold-migrate a VM with an SRIOV card passed through.

Actual results:
Fail with 'MigrationContext' object has no attribute 'old_pci_devices'

Expected results:
Migration succeeds

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1389284#c8
[2] https://code.engineering.redhat.com/gerrit/#/c/88986/
Comment 1 Artom Lifshitz 2016-11-10 01:01:45 UTC 
We're missing [1] in rhos9 - that's the patch that introduced version 1.1 of the MigrationContext, which added the old_pci_devices and new_pci_devices fields to the object. It's a big patch - 240 lines spread over a dozen files, so its backportability remains to be determined. In the meantime, we need to revert [2] out of rhos9.

[1] https://review.openstack.org/#/c/307124/
[2] https://code.engineering.redhat.com/gerrit/#/c/88986/
Comment 12 errata-xmlrpc 2016-12-21 16:38:22 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2992.html