Bug 1393695

Summary:	Cannot show annotation when deployment triggered by image change from jenkins
Product:	OpenShift Container Platform	Reporter:	Dongbo Yan <dyan>
Component:	ImageStreams	Assignee:	Ben Parees <bparees>
Status:	CLOSED NOTABUG	QA Contact:	Wang Haoran <haowang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.4.0	CC:	aos-bugs, bparees, gmontero, jokerman, mmccomas, tdawson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-22 23:07:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Dongbo Yan 2016-11-10 07:51:05 UTC

Description of problem:
Cannot show annotation when deployment triggered by image change from jenkins

Version-Release number of selected component (if applicable):
brew-pulp.../openshift3/jenkins-2-rhel7           20e80cb29407     brew-pulp.../openshift3/jenkins-1-rhel7           91ba1b4bff1d
openshift-login    0.8
openshift-pipeline 1.0.32	
openshift-sync     0.0.15

openshift v3.4.0.23+24b1a58
kubernetes v1.4.0+776c994
etcd 3.1.0-rc.0

How reproducible:
Always

Steps to Reproduce:
1.Login openshift and create a new project
2.Setup jenkins server and generate application under project
$oc new-app https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/jenkins-ephemeral-template.json
$oc new-app -f https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/application-template.json

3.Go to jenkins job page to create job
  click "new item" -->write item name: testplugin-->select "Freestyle project"-->save

4.Configure job to trigger build
  click "Add build step"---->"Trigger OpenShift Build "
  buildConfig: frontend

5.Wait build completed, deployments and deploy pod  created. Check deployment annotation in openshift webconsole

Actual results:
Cannot show annonation about trigger from jenkins

Expected results:
Could show annonation about trigger from jenkins, like:
"openshift.io/jenkins-build-uri 	https://jenkins-dyanv2.1108-5-3.qe.rhcloud.com/job/sample-pipeline/1/"

Additional info:

Comment 1 Ben Parees 2016-11-10 15:10:37 UTC

https://github.com/openshift/origin/pull/11872

Comment 2 Ben Parees 2016-11-10 15:26:32 UTC

We recently changed the openshift plugin to no longer annotation deployments that are automatically triggered by builds unless you explicitly request the build step "verify deployments are triggered".

Also i'm updating the buildconfig in the referenced PR to no longer automatically trigger a deployment, because the intended use of this template is to have 2 explicit steps in a jenkins job:

1) trigger the build
2) trigger the deployment (which will result in an annotated deployment).

So i'm sending this back to QA to either:

1) add a "Verify deployments=true" setting to the build step (while keeping automatic=true in the DC's imagechangetrigger)

or

2) Add an explicit deployment step to their jenkins job and confirm the triggered deployment does have the annotation.

Comment 3 Dongbo Yan 2016-11-14 02:34:14 UTC

ok, if openshift plugin is no longer annotation deployments that are automatically triggered by builds, it is not a bug.
And we can disable related testcases.