| Summary: | snapshot history button in infra vm page does not function properly | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Aziza Karol <akarol> | ||||||
| Component: | UI - OPS | Assignee: | Zita Nemeckova <znemecko> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Aziza Karol <akarol> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.7.0 | CC: | cpelland, dclarizi, hkataria, jhardy, mpovolny, obarenbo, slukasik | ||||||
| Target Milestone: | GA | Keywords: | Regression, TestOnly | ||||||
| Target Release: | 5.8.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | infra:vm:snapshot | ||||||||
| Fixed In Version: | 5.8.0.0 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1395849 (view as bug list) | Environment: | |||||||
| Last Closed: | 2017-06-12 17:32:31 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1395849 | ||||||||
| Attachments: |
|
||||||||
Created attachment 1219240 [details]
page redirected to snapshot YY
Version:5.7.0.10-beta3.20161109111947_9a61b18 Zita, It looks like value of x_node here https://github.com/ManageIQ/manageiq/blob/master/app/controllers/vm_common.rb#L1807-L1809 is the id of selected parent folder node of a VM which is messing up the history link when VMs are hidden in the tree. Can you take a look and fix the id that is being passed in to x_history_add_item method. Let me know if you have any questions. Please look at any other calls to x_history_add_item method as well to make sure they all work as expected. Thanks, ~Harpreet New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/adbe1faf05a8cf6c6fd01a7a1e87827c7b5ba6e9 commit adbe1faf05a8cf6c6fd01a7a1e87827c7b5ba6e9 Author: Martin Hradil <himdel> AuthorDate: Wed Nov 16 14:19:51 2016 +0200 Commit: Oleg Barenboim <chessbyte> CommitDate: Wed Nov 16 12:36:09 2016 -0500 Merge pull request #12614 from ZitaNemeckova/fix_history_button_vm Fix history button in vm infra page (cherry picked from commit 804cf5e66e28d6370333148c4f2affc47a61de35) https://bugzilla.redhat.com/show_bug.cgi?id=1393708 app/controllers/mixins/vm_show_mixin.rb | 2 +- app/controllers/vm_common.rb | 29 +++++++++++++++++++++++------ 2 files changed, 24 insertions(+), 7 deletions(-) snapshot history button in infra vm page works fine. Verified:5.8.0.4.20170307183144_745a3d9 |
Created attachment 1219239 [details] accessing snapshot XX Description of problem: Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: Viewing history link of snapshot VM xx redirects to the snapshot page of vm yy see attached screenshots Actual results: should redirect to proper page Expected results: Additional info: