| Summary: | Review Request: golang-github-go-errors-errors - Package errors provides errors that have stack-traces | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gianluca Sforna <giallu> |
| Component: | Package Review | Assignee: | Dennis Chen <barracks510> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | barracks510, package-review |
| Target Milestone: | --- | Flags: | barracks510:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-27 05:19:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1394193 | ||
|
Description
Gianluca Sforna
2016-11-10 10:56:44 UTC
I don't think we'll be targeting EPEL6, at least not with the arduino releases, could you simplify the SPEC to remove of all the unnecessary macros? Just for clarification it seems we haven't approved official packaging guidelines, so I relied on the gofed tool and https://fedoraproject.org/wiki/PackagingDrafts/Go to build the spec file. That's where all those macro and stuff comes from. So, I cleaned it up a little, have a look at: Spec URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors.spec SRPM URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors-0-0.2.gita418503.fc24.src.rpm Ok. We can get rid of the ExclusiveArch, and then remove some unnecessary lines/comments:
%if 0%{?with_check} && ! 0%{?with_bundled}
%endif
%if 0%{?with_check}
#Here comes all BuildRequires: PACKAGE the unit tests
#in %%check section need for running
%endif
etc... And then I think we're good to go.
(In reply to Dennis Chen from comment #3) > Ok. We can get rid of the ExclusiveArch, the example mentions el6, but I am not sure it is limited to that. Without that macro, we need keep track manually of which archs golang is available. I think it would be wiser to keep it, but if you insist I will remove it. > and then remove some unnecessary > lines/comments: > > %if 0%{?with_check} && ! 0%{?with_bundled} > %endif Done > > %if 0%{?with_check} > #Here comes all BuildRequires: PACKAGE the unit tests > #in %%check section need for running > %endif Done > > etc... And then I think we're good to go. and done See: Spec URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors.spec SRPM URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors-0-0.3.gita418503.fc24.src.rpm Ping? (In reply to Gianluca Sforna from comment #5) > Ping? Sorry, Approved. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-go-errors-error Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-go-errors-errors golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6e81af815 golang-github-go-errors-errors-0-0.3.gita418503.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-77b140109e golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6e81af815 golang-github-go-errors-errors-0-0.3.gita418503.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-77b140109e golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. golang-github-go-errors-errors-0-0.3.gita418503.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. golang-github-go-errors-errors-0-0.3.gita418503.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |