Bug 1393854

Summary: The error info is not accurate when setting invalid VIRT_ADMIN_DEBUG
Product: Red Hat Enterprise Linux 7 Reporter: Lili Zhu <lizhu>
Component: libvirtAssignee: Erik Skultety <eskultet>
Status: CLOSED ERRATA QA Contact: Yanqiu Zhang <yanqzhan>
Severity: low Docs Contact:
Priority: unspecified    
Version: 7.3CC: dyuan, fjin, jdenemar, rbalakri, xuzhang, zpeng
Target Milestone: rc   
Target Release: 7.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-2.5.0-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 17:19:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lili Zhu 2016-11-10 13:09:13 UTC
Description of problem:
The error info is not accurate when setting invalid VIRT_ADMIN_DEBUG

How producible
100%

Version:
libvirt-2.0.0-10.el7_3.1.x86_64


Steps to Reproduce:
1. # export VIRT_ADMIN_DEBUG=-1
2. # virt-admin


Actual results:
 error: VSH_DEBUG not set with a valid numeric value


Expected results:
 error: VIRT_ADMIN_DEBUG not set with a valid numeric value

Comment 1 Erik Skultety 2016-11-11 12:58:30 UTC
Fixed upstream by:

commit 7b8e1dff1af5146db50c78b5b6912aba6f8ea52b
Author:     Erik Skultety <eskultet>
AuthorDate: Fri Nov 11 13:39:45 2016 +0100
Commit:     Erik Skultety <eskultet>
CommitDate: Fri Nov 11 13:44:40 2016 +0100

    vsh: Fix the incorrect environment variable prefix in error message
    
    Unlike the other error messages in vshInitDebug, this one relied on a hardcoded
    name of a variable instead of using the prefix of the tool calling the init
    routine.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1393854
    
    Signed-off-by: Erik Skultety <eskultet>

v2.4.0-79-g7b8e1df

Comment 3 Yanqiu Zhang 2017-02-03 08:52:54 UTC
Reproduce this bug on libvirt-2.0.0-10.el7.x86_64
Steps to reproduce:
1.# export VIRT_ADMIN_DEBUG=-1
  # virt-admin
error: VSH_DEBUG not set with a valid numeric value
......


Verify this bug on libvirt-2.5.0-1.el7.x86_64
Steps to verify:
1.# export VIRT_ADMIN_DEBUG=-1
  # virt-admin                
error: VIRT_ADMIN_DEBUG not set with a valid numeric value
......

2.# export VIRSH_DEBUG=-1
   # virsh                 
error: VIRSH_DEBUG not set with a valid numeric value
......

Since the results are as expected, mark this bug as verified.

Comment 4 errata-xmlrpc 2017-08-01 17:19:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846

Comment 5 errata-xmlrpc 2017-08-01 23:59:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846