Bug 1393918

Summary: Move ancillary commands to jsonrpc
Product: [oVirt] ovirt-hosted-engine-setup Reporter: Simone Tiraboschi <stirabos>
Component: GeneralAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED CURRENTRELEASE QA Contact: Nikolai Sednev <nsednev>
Severity: medium Docs Contact:
Priority: high    
Version: 2.0.3.1CC: bmcclain, bugs, mavital, melewis, stirabos, ylavi
Target Milestone: ovirt-4.1.0-betaKeywords: Improvement, Triaged
Target Release: 2.1.0Flags: rule-engine: ovirt-4.1+
bmcclain: exception+
nsednev: testing_plan_complete+
rule-engine: planning_ack+
sbonazzo: devel_ack+
mavital: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: Doc Type: Enhancement
Doc Text:
With this update, some ancillary self-hosted engine commands that were still based on xmlrpc have been moved to jsonrpc.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-01 14:41:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Simone Tiraboschi 2016-11-10 15:39:46 UTC
Description of problem:
Currently a few ancillary hosted-engine commands:

 hosted-engine --vm-start
 hosted-engine --vm-start-paused
 hosted-engine --vm-shutdown
 hosted-engine --vm-poweroff
 hosted-engine --add-console-password
 hosted-engine --console (call list vms:"${vmid}" to provide a better error message)

are just implemented as bash wrapped to vdsClient commands.
vdsClient still uses xmlrc, move somehow to jsonrpc.

Comment 1 Yaniv Lavi 2016-11-23 08:14:46 UTC
Can you provide the missing commands in the current client?

Comment 2 Simone Tiraboschi 2016-12-14 11:22:38 UTC
(In reply to Yaniv Dary from comment #1)
> Can you provide the missing commands in the current client?

AFAIK vdsClient command still uses XMLRPC for everything and we don't have a different CLI tool based on jsonrpc.

Comment 3 Nikolai Sednev 2016-12-21 16:25:04 UTC
Please provide reproduction steps for this bug, so we could verify it properly.

Comment 4 Simone Tiraboschi 2016-12-21 18:18:35 UTC
(In reply to Nikolai Sednev from comment #3)
> Please provide reproduction steps for this bug, so we could verify it
> properly.

Simply execute:
 hosted-engine --vm-start
 hosted-engine --vm-start-paused
 hosted-engine --vm-shutdown
 hosted-engine --vm-poweroff
 hosted-engine --add-console-password
 hosted-engine --console

and ensure that all of them are working as they were before.

Comment 7 Nikolai Sednev 2017-01-25 15:06:49 UTC
Works for me on these components on host:
rhvm-appliance-4.1.20170119.1-1.el7ev.noarch
ovirt-hosted-engine-ha-2.1.0-1.el7ev.noarch
ovirt-host-deploy-1.6.0-1.el7ev.noarch
ovirt-imageio-common-0.5.0-0.el7ev.noarch
ovirt-vmconsole-host-1.0.4-1.el7ev.noarch
qemu-kvm-rhev-2.6.0-28.el7_3.3.x86_64
libvirt-client-2.0.0-10.el7_3.4.x86_64
mom-0.5.8-1.el7ev.noarch
vdsm-4.19.2-2.el7ev.x86_64
ovirt-hosted-engine-setup-2.1.0-2.el7ev.noarch
ovirt-setup-lib-1.1.0-1.el7ev.noarch
ovirt-engine-sdk-python-3.6.9.1-1.el7ev.noarch
ovirt-imageio-daemon-0.5.0-0.el7ev.noarch
ovirt-vmconsole-1.0.4-1.el7ev.noarch
sanlock-3.4.0-1.el7.x86_64
Linux version 3.10.0-514.6.1.el7.x86_64 (mockbuild.eng.bos.redhat.com) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-11) (GCC) ) #1 SMP Sat Dec 10 11:15:38 EST 2016
Linux 3.10.0-514.6.1.el7.x86_64 #1 SMP Sat Dec 10 11:15:38 EST 2016 x86_64 x86_64 x86_64 GNU/Linux
Red Hat Enterprise Linux Server release 7.3 (Maipo)