Bug 1393922

Summary:	[CodeChange][RFE] ovirt-hosted-engine-ha: rebase on the new jsonrpc client
Product:	[oVirt] ovirt-hosted-engine-ha	Reporter:	Simone Tiraboschi <stirabos>
Component:	RFEs	Assignee:	Andrej Krejcir <akrejcir>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Artyom <alukiano>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.0.4	CC:	akrejcir, bugs, dfediuck, mavital, stirabos, ykaul, ylavi
Target Milestone:	ovirt-4.2.0	Keywords:	CodeChange, FutureFeature, Rebase, Triaged
Target Release:	2.2.0	Flags:	rule-engine: ovirt-4.2+ mavital: testing_plan_complete- ylavi: planning_ack+ dfediuck: devel_ack+ mavital: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 11:14:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	SLA	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Simone Tiraboschi 2016-11-10 16:03:41 UTC

Description of problem:
the current VDSM jsonrpcclient will be deprecated in favor of a simple string based client.
The new client is under review here:
https://gerrit.ovirt.org/#/c/64502/

The call mechanism will change from:
 cli.getVmStats('bc26bd11-ee3b-4a56-80d4-770f383a47b9')
to
 cli.call('VM.getStats', {'vmID': 'bc26bd11-ee3b-4a56-80d4-770f383a47b9'})

Rebase all the code on the new client.

Comment 1 Yaniv Lavi 2017-06-06 20:54:56 UTC

Why is this high priority?

Comment 2 Yaniv Kaul 2017-06-06 21:24:51 UTC

(In reply to Yaniv Lavi from comment #1)
> Why is this high priority?

I thought it was part of the work to use the persistent connection, which should reduce the CPU usage of the agent.

Comment 3 Yaniv Lavi 2017-06-11 13:02:34 UTC

(In reply to Yaniv Kaul from comment #2)
> (In reply to Yaniv Lavi from comment #1)
> > Why is this high priority?
> 
> I thought it was part of the work to use the persistent connection, which
> should reduce the CPU usage of the agent.

Don't think so.
Simone, is this needed for persistent connections?

Comment 4 Sandro Bonazzola 2017-06-21 12:44:50 UTC

Andrej is already working on this

Comment 5 Simone Tiraboschi 2017-07-31 09:49:44 UTC

(In reply to Yaniv Kaul from comment #2)
> (In reply to Yaniv Lavi from comment #1)
> > Why is this high priority?
> 
> I thought it was part of the work to use the persistent connection, which
> should reduce the CPU usage of the agent.

It's not really needed for persistent connection although strictly related since it's affecting the same code area.

Comment 6 Artyom 2017-10-15 08:58:50 UTC

Hi, can give me some tips how can I verify this bug in the best way?

Comment 7 Andrej Krejcir 2017-10-16 08:28:23 UTC

This bug does not add any functionality, so it should be ok, to verify that normal functionality works. Maybe using OST.

Or do we want to be thorough and test that each RPC call works?
(I did it during patch verification, but maybe I missed something)

Comment 8 Artyom 2017-10-31 11:22:58 UTC

I ran our hosted-engine-ha test, and all works as expected, so I will verify the bug.
Verified on ovirt-hosted-engine-ha-2.2.0-0.0.master.20171026143552.20171026143550.gitcbe3c76.el7.centos.noarch

Comment 9 Sandro Bonazzola 2017-12-20 11:14:19 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.