Bug 1394046

Summary:	Review Request: python3-netaddr - A pure Python network address representation and manipulation library
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ybronhei, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-16 16:05:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Orion Poplawski 2016-11-10 21:44:03 UTC

Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-netaddr.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-netaddr-0.7.18-1.el7.src.rpm

Description:
A pure Python network address representation and manipulation library.

netaddr provides a Pythonic way of working with :-

- IPv4 and IPv6 addresses and subnets
- MAC addresses, OUI and IAB identifiers, IEEE EUI-64 identifiers
- arbitrary (non-aligned) IP address ranges and IP address sets
- various non-CIDR IP range formats such as nmap and glob-style formats

Included are routines for :-

- generating, sorting and summarizing IP addresses and networks
- performing easy conversions between address notations and formats
- detecting, parsing and formatting network address representations
- performing set-based operations on groups of IP addresses and subnets
- working with arbitrary IP address ranges and formats
- accessing OUI and IAB organisational information published by IEEE
- accessing IP address and block information published by IANA

For details on the latest updates and changes, see :-

    http://github.com/drkjam/netaddr/blob/rel-0.7.x/CHANGELOG

API documentation for the latest release is available here :-

    http://packages.python.org/netaddr/

Fedora Account System Username: orion

This is an EPEL only package

EPEL7: http://koji.fedoraproject.org/koji/taskinfo?taskID=16389853

Comment 1 Orion Poplawski 2016-11-10 21:45:41 UTC

*** Bug 1322827 has been marked as a duplicate of this bug. ***

Comment 2 Zbigniew Jędrzejewski-Szmek 2016-11-13 23:11:03 UTC

All this applies to the "upstream" python-netaddr.spec too, it'd be best to fix it there too:

%description is too long to be repeated, it should be defined as a macro.

%{__sed} → sed [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros].

" :-" is strange...

rpmlint:
python34-netaddr.noarch: E: wrong-script-interpreter /usr/bin/netaddr-3.4 /usr/bin/env python
python34-netaddr.noarch: W: install-file-in-docs /usr/share/doc/python34-netaddr-0.7.18/INSTALL

Those are both valid.

Anyway:
+ package name is OK
+ license is acceptable (BSD)
+ license is specified correctly
+ builds and installs OK
+ provides/requires look correct
+ no scriptlets
+ python macros are used
+ %python_provide is not needed for EPEL

Package is APPROVED. Please consider cleaning up stuff listed above.

Comment 3 Orion Poplawski 2016-11-14 15:42:14 UTC

Changes made here and in Fedora.  Thanks for the review.

Comment 4 Gwyn Ciesla 2016-11-14 15:50:05 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-netaddr

Comment 5 Fedora Update System 2016-11-14 16:25:54 UTC

python3-netaddr-0.7.18-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-58bea500fe

Comment 6 Fedora Update System 2016-11-15 14:23:29 UTC

python3-netaddr-0.7.18-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-58bea500fe

Comment 7 Fedora Update System 2018-01-16 16:05:15 UTC

python3-netaddr-0.7.18-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.