Bug 1394250

rpmlint:

$ rpmlint SPECS/python-async_timeout.spec  SRPMS/python-async_timeout-1.1.0-1.fc25.src.rpm RPMS/noarch/python3-async_timeout-1.1.0-1.fc25.noarch.rpm 
python-async_timeout.src: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-async_timeout.src: W: summary-not-capitalized C asyncio-compatible timeout context manager
python-async_timeout.src: W: spelling-error %description -l en_US asyncio -> Asuncion
python3-async_timeout.noarch: W: spelling-error Summary(en_US) asyncio -> Asuncion
python3-async_timeout.noarch: W: summary-not-capitalized C asyncio-compatible timeout context manager
python3-async_timeout.noarch: W: spelling-error %description -l en_US asyncio -> Asuncion
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

Sorry, copy-paste typo:

Spec URL: https://athmane.fedorapeople.org/pkgs/python-async_timeout.spec
SRPM URL: https://athmane.fedorapeople.org/pkgs/python-async_timeout-1.1.0-1.fc25.src.rpm

%description should say what this package does. Not everybody is versed with upstream python development enough to immediately understand what asyncio is and what this package is useful for.

The underscore should be replaced with a dash in the name ("python-async-timeout") [https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Separators].

Any chance you could submit pytest_aiohttp for review too? Sounds like a useful package for asyncio users.

It'd be nice to use a more precise glob in %files, something like
%{python3_sitelib}/async_timeout/
%{python3_sitelib}/async_timeout-*%{python3_version}.egg-info

Thanks alot for reviewing, please find below the update.

Wrt underscore, IMHO it's only forbidden if it's a separator, in our case it's part of the name, we have python modules and other packages that contain _ (I myself have couple Apache httpd modules).

It can be checked with: 

dnf repoquery --qf '%{name}' python\*_\*
dnf repoquery --qf '%{name}' \*_\*

I'll submit pytest_aiohttp soon, but for now we need this pkg in order to fix python3-aiohttp issues, which is breaking GNS3 (see blocked bugs)


SPEC: https://athmane.fedorapeople.org/pkgs/python-async_timeout.spec
SRPM: https://athmane.fedorapeople.org/pkgs/python-async_timeout-1.1.0-2.fc25.src.rpm

"_" was commonly used, but nowadays "-" is preferred. There's no strict rule, but if you e.g. look at python packages it's pretty clear: F24 has 3597 'python*' packages, and among that only 84 with an underscore. "Package names should be in lower case and use dashes in preference to underscores." (BTW, the upstream is confused too, since they use async-timeout for the the url and directory names...)

OK, looks good apart from the name. There is no "MUST" guidelines, but please consider changing it.

* I would prefer to name it `python-async-timeout`.
* Missing BR: pythonX-setuptools
* %{python3_sitelib}/async_timeout-*%{python3_version}.egg-info -> %{python3_sitelib}/async_timeout-*.egg-info/

Thanks for the feedback, update below.

SPEC: https://athmane.fedorapeople.org/pkgs/python-async-timeout.spec
SRPM: https://athmane.fedorapeople.org/pkgs/python-async-timeout-1.1.0-3.fc25.src.rpm

+ package name is OK ;)
+ license is acceptable (ASL 2.0)
+ license is specified correctly
+ builds and install OK
+ fedora-review is happy
+ provides/requires seem correct
+ python packaging macros are used
+ %python_provide is present
+ latest version

Package is APPROVED.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-async-timeout

python-async-timeout-1.1.0-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-da89a216e8

python-async-timeout-1.1.0-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-da89a216e8

Can you push this package to fedora 24 too? I need it in one of my program.

python-async-timeout-1.1.0-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-aea351b543

Hi Julien, 

Pushed to f24 updates-testing

python-async-timeout-1.1.0-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aea351b543

Thanks!

python-async-timeout-1.1.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

python-async-timeout-1.1.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.