Bug 1394262

Summary: Review Request: perl-Net-CardDAVTalk - CardDAV client
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Net-CardDAVTalk-0.03-1.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-05 21:41:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1394174, 1394183, 1394242    
Bug Blocks:    

Description Petr Pisar 2016-11-11 14:00:25 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Net-CardDAVTalk/perl-Net-CardDAVTalk.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Net-CardDAVTalk/perl-Net-CardDAVTalk-0.03-1.fc26.src.rpm
Description:
This is an CardDAV client with FastMail Perl API.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-11-23 09:07:37 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Net-CardDAVTalk-0.03-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(List::Pairwise) >= 1.00
      1 perl(Net::DAVTalk) >= 0.08
      1 perl(Text::VCardFast) >= 0.07
      1 perl(XML::Spice) >= 0.04
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Many requires are not listed due to missing BR perl-generators

$ rpm -qp --provides perl-Net-CardDAVTalk-0.03-1.fc26.noarch.rpm | sort | uniq -c
      1 perl-Net-CardDAVTalk = 0.03-1.fc26
FIX: The list of provides is not complete due to missing BR perl-generators

$ rpmlint ./perl-Net-CardDAVTalk*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires
FIX: Add build-require perl-generators to have complete list of requires and provides.

Please correct 'FIX' issue before submit.

Otherwise package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-11-23 13:31:23 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-CardDAVTalk

Comment 3 Petr Pisar 2016-11-23 15:04:17 UTC
Thank you for the review and the repository. I added the forgotten dependency.

Comment 4 Fedora Update System 2016-11-23 15:20:31 UTC
perl-Net-CardDAVTalk-0.03-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c31e55bc3e

Comment 5 Fedora Update System 2016-11-23 15:27:40 UTC
perl-Net-CardDAVTalk-0.03-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-132d7771c8

Comment 6 Fedora Update System 2016-11-25 09:39:13 UTC
perl-Net-CardDAVTalk-0.03-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-132d7771c8

Comment 7 Fedora Update System 2016-11-25 09:42:10 UTC
perl-Net-CardDAVTalk-0.03-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c31e55bc3e

Comment 8 Fedora Update System 2016-12-05 21:41:26 UTC
perl-Net-CardDAVTalk-0.03-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-12-06 10:25:19 UTC
perl-Net-CardDAVTalk-0.03-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.