Bug 1394576
| Summary: | Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Athos Ribeiro <athoscribeiro> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-10 16:02:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1206883 | ||
| Bug Blocks: | 1426972 | ||
|
Description
Athos Ribeiro
2016-11-13 19:49:15 UTC
New version Spec URL:https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell-1.1.0-1.src.rpm New sources Spec URL:https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell-1.1.0-3.fc25.src.rpm Taking this review. Initial comments: 1) You can remove the empty %if-%endif block in the -unit-test-devel package section (at lines 77-80). 2) You are simply disabling one of the tests - have you reported the failing test upstream? Maybe this can be fixed upstream so you can run all tests for this package. 3) What does the GOPATH definition in line 136 mean? I don't see the Godeps directory in the source tarball. Is this there by mistake? 4) You can use the following Source URL to avoid ugly hackery: https://%{provider_prefix}/archive/v%{version}/%{name}-%{version}.tar.gz 1) Fixed 2 and 3 were changes from another version which I forgot to remove. Both are fixed now 4) Fixed Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell-1.1.0-4.fc25.src.rpm Looks good to me now. One additional nitpick, not a blocker but "nice to have": Please include the %commit and %shortcommit definitions produced by gofed (according to the used git tag) in the ".spec header" - this is used by automatic golang tooling for version tracking.
%global commit 0bcb03f4b4d0a9428594752bd2a3b9aa0a9d4bd4
%global shortcommit %(c=%{commit}; echo ${c:0:7})
OK! I will do that before building it. Thank you for the review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-PuerkitoBio-purell golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ebaa73819 golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ebaa73819 golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |