Bug 1394614

I already know that `rpmlint --info` throws an error:

> rpmlint --info gnome-shell-extension-topicons-plus-17-1.fc24.noarch.rpm 
gnome-shell-extension-topicons-plus.noarch: E: explicit-lib-dependency glib2
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

...but I'm not sure how to deal with this. TopIcons Plus requires the gsettings command, which according to rpm --query, is provided by glib2. So I do have to specify glib2 as a dependency, and I'm not sure how I could make it less "explicit" to make rpmlint happy.

Correction: *installing* TopIcons Plus requires the gsettings command. As far as I know, the extension itself doesn't need it, but as noted in a comment in the spec file, upstream recommends using gsettings to disable version validation during installation.

Updated to TopIcons Plus version 19.

gsettings command no longer needed, so glib2 is no longer a dependency.

Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-topicons-plus/raw/master/gnome-shell-extension-topicons-plus.spec

SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-topicons-plus-19-1.fc25.src.rpm

fedora-review looks good to me, except that it still complains about glib-schemas:

  Issues:
  =======
  - glib-compile-schemas is run in %postun and %posttrans if package has
    *.gschema.xml files.
    Note: gschema file(s) in gnome-shell-extension-topicons-plus
    See:
    http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema

I still don't quite get what this is telling me. The `glib-compile-schemas` appears only in the extension's Makefile's "build" target.

  https://github.com/phocean/TopIcons-plus/blob/master/Makefile

Is fedora-review saying that I'm supposed to remove the glib-compile-schemas command?

* Updated to upstream version 20.
* Moved gschema file to system glib directory.
* Demoted GNOME Tweak Tool from a Require to a Recommend.

Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-topicons-plus/raw/master/gnome-shell-extension-topicons-plus.spec

SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-topicons-plus-20-1.fc26.src.rpm

Schema compilation is not needed, see https://bugzilla.redhat.com/show_bug.cgi?id=1396790#c9.

+ latest version
+ builds and installs and runs OK
+ license is acceptable (GPLv2)
+ license is specified correctly
+ package name is OK
+ no scriptlets needed
+ BR/R/P look correct
 
Package is APPROVED.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-topicons-plus

gnome-shell-extension-topicons-plus-20-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e530405e6

gnome-shell-extension-topicons-plus-20-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef36437454

gnome-shell-extension-topicons-plus-20-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-976faa2478

Thanks for packaging this!

But I have one remark. Shouldn't be everything beginning "**NOTE:**" stripped out from the description? This is what guidelines [1] say about it:

> Do not include installation instructions in the description; it is not
> a manual. If the package requires some manual configuration or there are
> other important instructions to the user, refer the user to the documentation
> in the package. Add a README.Fedora, or similar, if you feel this is necessary.

I don't think the description applies anyway. Neither I suggest adding the README, since this should work out of box after installation, right?

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

gnome-shell-extension-topicons-plus-20-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef36437454

gnome-shell-extension-topicons-plus-20-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-976faa2478

gnome-shell-extension-topicons-plus-20-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e530405e6

gnome-shell-extension-topicons-plus-20-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

gnome-shell-extension-topicons-plus-20-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

gnome-shell-extension-topicons-plus-20-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.