Bug 1394668

Summary:	Not all connections have an interface name
Product:	Red Hat Enterprise Linux 7	Reporter:	Dominik Perpeet <dperpeet>
Component:	cockpit	Assignee:	Dominik Perpeet <dperpeet>
Status:	CLOSED CURRENTRELEASE	QA Contact:	qe-baseos-daemons
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.3	CC:	dperpeet, mvollmer, stefw
Target Milestone:	rc	Keywords:	Extras
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-13 11:23:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Dominik Perpeet 2016-11-14 08:01:07 UTC

Description of problem:
Not all connections have an interface name

Version-Release number of selected component (if applicable):
122-1

How reproducible:
Always

Additional info:
Fixed upstream d957f9e682a8bd5a9e005b730ce5a7f5317b2ed7

Comment 1 Dominik Perpeet 2016-11-14 08:40:12 UTC

Upstream master commit
https://github.com/cockpit-project/cockpit/commit/5d3f012faf468235954083312b1bd15ac8fc29c8

Comment 2 Stef Walter 2016-11-14 08:54:38 UTC

We should describe the actual problem caused by this bug before approving it for a patch. Dominik, do you have that information?

Comment 3 Marius Vollmer 2016-11-14 13:52:02 UTC

Here is the background for the patch:

Cockpit builds a internal data structure that is derived from the information exposed by NetworkManager.  Specifically, it finds all names of interfaces that don't currently exist in the kernel but can be potentially created by activating existing connection settings for bridges, bonds, teams, or vlans.

Previously, Cockpit assumed that all connection settings for bridges, bonds, teams, and vlans have a value for the "interface-name" property.  It would crash if a setting didn't have a value.

These kind of incomplete settings are legal and work okay with NetworkManager.  We would need more work in Cockpit to also make them work okay in the UI.

Comment 4 Dominik Perpeet 2016-11-14 13:54:37 UTC

This patch prevents (In reply to Marius Vollmer from comment #3)
> Previously, Cockpit assumed that all connection settings for bridges, bonds,
> teams, and vlans have a value for the "interface-name" property.  It would
> crash if a setting didn't have a value.

We want to prevent said crash.

Comment 5 Dominik Perpeet 2017-09-13 11:23:44 UTC

current version contains the patch