Bug 1394830

Summary: The latest version of scapy breaks the DHCP validator
Product: Red Hat OpenStack Reporter: Udi Kalifon <ukalifon>
Component: openstack-tripleo-validationsAssignee: Tomas Sedovic <tsedovic>
Status: CLOSED ERRATA QA Contact: Ola Pavlenko <opavlenk>
Severity: urgent Docs Contact: RHOS Documentation Team <rhos-docs>
Priority: unspecified    
Version: 10.0 (Newton)CC: akrivoka, apannu, dtrainor, jjoyce, jrist, jschluet, slinaber, tvignaud
Target Milestone: rcKeywords: Triaged
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-validations-5.1.0-5.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-14 16:32:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Udi Kalifon 2016-11-14 14:24:22 UTC
Description of problem:
Running the validator "DHCP on the Provisioning Network" results with:

Task 'Look for DHCP responses' failed:
Host: localhost
Message: Script `files/rogue_dhcp.py enp5s0f1` exited with code: 1

stderr:
    Traceback (most recent call last):
      File "/home/validations/.ansible/tmp/ansible-tmp-1479130289.59-266387329408030/rogue_dhcp.py", line 23, in <module>
        from scapy.all import BOOTP
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/all.py", line 28, in <module>
        from scapy.route6 import *
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/route6.py", line 273, in <module>
        conf.route6 = Route6()
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/route6.py", line 31, in __init__
        self.resync()
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/route6.py", line 44, in resync
        self.routes = read_routes6()
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/arch/linux.py", line 283, in read_routes6
        cset = scapy.utils6.construct_source_candidate_set(d, dp, devaddrs, LOOPBACK_NAME)
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/utils6.py", line 50, in construct_source_candidate_set
        if in6_isgladdr(addr) or in6_isuladdr(addr):
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/utils6.py", line 708, in in6_isgladdr
        return in6_isincluded(str, '2000::', 3)
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/utils6.py", line 651, in in6_isincluded
        temp = inet_pton(socket.AF_INET6, addr)
      File "/tmp/validations-venv/lib/python2.7/site-packages/scapy/pton_ntop.py", line 40, in inet_pton
        raise Exception("Illegal syntax for IP address")
    Exception: Illegal syntax for IP address

Failure! The validation failed for the following hosts:
* localhost


Version-Release number of selected component (if applicable):
openstack-tripleo-validations-5.1.0-3.el7ost.noarch


How reproducible:
100%

Comment 1 Jason E. Rist 2016-11-14 16:43:25 UTC
*** Bug 1394829 has been marked as a duplicate of this bug. ***

Comment 2 Tomas Sedovic 2016-11-14 17:41:33 UTC
Fix submitted upstream: https://review.openstack.org/#/c/397314/

Comment 3 Tomas Sedovic 2016-11-15 12:52:47 UTC
The upstream patch has merged, here's the backport to stable/newton: https://review.openstack.org/397727

Comment 4 Jason E. Rist 2016-11-15 20:23:32 UTC
Removing the blocker flag, as there is a patch posted upstream. Not a blocker due to it being a single validation case.

Comment 5 Tomas Sedovic 2016-11-16 12:08:38 UTC
The backport has merged, too.

Comment 7 Ana Krivokapic 2016-11-25 14:04:23 UTC
Works in openstack-tripleo-validations-5.1.0-5.el7ost.noarch

Comment 9 errata-xmlrpc 2016-12-14 16:32:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2948.html