Bug 1394952

Summary: Review Request: python-avocado - Framework with tools and libraries for Automated Testing
Product: [Fedora] Fedora Reporter: Merlin Mathesius <mmathesi>
Component: Package ReviewAssignee: Stephen Gallagher <sgallagh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mmathesi, package-review, sgallagh
Target Milestone: ---Flags: sgallagh: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-05 21:41:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Mock failure during fedora-review of python-avocado-43.0-3 none

Description Merlin Mathesius 2016-11-14 20:57:36 UTC 
Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-1.fc24.src.rpm
COPR build URL: https://copr.fedoraproject.org/coprs/merlinm/avocado/build/476635/
Description:

Avocado is a set of tools and libraries (what people call
these days a framework) to perform automated testing.

Fedora Account System Username: merlinm
Comment 1 Merlin Mathesius 2016-11-15 16:21:44 UTC 
Updates made based on comments and discussions in #fedora-modularity.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-2.fc24.src.rpm
COPR build URL: https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/476977/
Comment 2 Merlin Mathesius 2016-11-15 22:37:11 UTC 
Updated with additional patch to skip buggy selftest causing builds to occasionally fail as discussed in #fedora-modularity.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-3.fc24.src.rpm
COPR build URL: https://copr.fedoraproject.org/coprs/merlinm/avocado/build/477093/
Comment 3 Stephen Gallagher 2016-11-16 01:06:47 UTC 
Created attachment 1221004 [details]
Mock failure during fedora-review of python-avocado-43.0-3

This is still failing to build intermittently in mock. See attachment.
Comment 4 Merlin Mathesius 2016-11-16 19:49:16 UTC 
After looking through the avocado selftests, there appear to be many more potential race conditions that may randomly cause build failures. Thus, the selftests have been commented out with a note about the situation. The patches for the selftests have also been removed, since they are no longer relevant.

An upstream issue has been raised: https://github.com/avocado-framework/avocado/issues/1619

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-4.fc24.src.rpm
COPR build URL: https://copr.fedoraproject.org/coprs/merlinm/avocado/build/477928/
Comment 5 Stephen Gallagher 2016-11-17 15:03:56 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== Issues =====

* License: field only describes GPLv2, but the licensecheck shows MIT
  license as well. Please also check whether GPLv2 or GPLv2+ is correct.

* Requires for the main package should be for python2-%{srcname}, not
  python-%{srcname}

* Requires for subpackages on the main package must be fully versioned. e.g.:
  Requires: python2-%{srcname} == %{version}-%{release}
  This is to ensure that if a user runs `dnf update python2-avocado`, they are
  guaranteed to get the subpackage built together with it. If there is a
  special reason this should not happen, it needs to be in a comment in the
  spec file.

* Package uses but does not own /usr/share/avocado, /usr/share/doc/avocado,
  /etc/avocado/scripts/job, /etc/avocado/scripts, /usr/libexec/avocado

* The BuildRequires should use the python2-foo variant of the Requires, since
  the package does not support python3. The unversioned python-foo Requires is
  now reserved for packages that can switch between them (so that in the future
  the %{python_provides} macro will change which version supplies the
  unversioned name.

* The python2-avocado-plugins-output-html subpackage bundles a
  font, glyphicons-halflings-regular. This does not appear to be actually
  freely licensed for use in Fedora. Glyphicons.com appears to charge for this
  font, though it is available "for free" (no license specified) if installed
  through bootstrap (which this package does not use). See
  http://getbootstrap.com/components/#glyphicons for the line "Glyphicons
  Halflings are normally not available for free, but their creator has made them
  available for Bootstrap free of cost.

  Unfortunately, "free of cost" is not the same thing as "freely distributable".

  This needs to be discussed with upstream urgently.

* The python-avocado-examples subpackage needs to put all of its contents into
  the %{_docdir} hierarchy rather than %{python2_sitelib}. They are not runtime
  contents.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "GPL (v2 or later)", "Unknown or generated", "*No
     copyright* GPL", "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or
     later)", "GPL (v2)". 253 files have unknown license. Detailed output
     of licensecheck in /home/sgallagh/1394952-python-
     avocado/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/avocado, /usr/share/doc/avocado,
     /etc/avocado/scripts/job, /etc/avocado/scripts, /usr/libexec/avocado
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/avocado/scripts/job,
     /etc/avocado/scripts, /usr/share/doc/avocado, /usr/libexec/avocado,
     /usr/share/avocado
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[X]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-avocado , python2-avocado-plugins-output-html , python-
     avocado-examples
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-avocado-43.0-4.fc26.noarch.rpm
          python2-avocado-plugins-output-html-43.0-4.fc26.noarch.rpm
          python-avocado-examples-43.0-4.fc26.noarch.rpm
          python-avocado-43.0-4.fc26.src.rpm
python2-avocado-plugins-output-html.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
python2-avocado-plugins-output-html.noarch: W: no-documentation
python-avocado-examples.noarch: W: no-documentation
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/datadir.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/datadir.py 644 /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/return99.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/cabort.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/passtest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/raise.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/datadir.py.data/datadir.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptest.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree_nasty.py.data/doublefree.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gdbtest.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/segfault.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree_nasty.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiple_tests.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/multiple_tests.py 644 /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/raise.py.data/raise.c
python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/output_check.sh.data/stderr.expected
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree.py.data/doublefree.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/modify_variable.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/modify_variable.py.data/print_variable.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/fail_on_exception.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty2.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiplextest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skip_outside_setup.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptenmin.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gendata.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skiponsetup.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/skiponsetup.py 644 /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty3.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/synctest.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/cabort.py.data/abort.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/whiteboard.py /usr/bin/env python
python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/synctest.py.data/stderr.expected
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/linuxbuild.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/failtest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/timeouttest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/abort.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/abort.py 644 /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/warntest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/trinity.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/uncaught_exception.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/uncaught_exception.py 644 /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefail.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty.py /usr/bin/env python
4 packages and 0 specfiles checked; 37 errors, 11 warnings.




Rpmlint (installed packages)
----------------------------
python2-avocado-plugins-output-html.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
python2-avocado-plugins-output-html.noarch: W: no-documentation
python-avocado-examples.noarch: W: no-documentation
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptenmin.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/synctest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/abort.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/abort.py 644 /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/segfault.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty3.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gdbtest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty.py /usr/bin/env python
python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/synctest.py.data/stderr.expected
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/cabort.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty2.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree_nasty.py.data/doublefree.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skip_outside_setup.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/raise.py.data/raise.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/whiteboard.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/passtest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/fail_on_exception.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/modify_variable.py.data/print_variable.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/modify_variable.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gendata.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiple_tests.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/multiple_tests.py 644 /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/trinity.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/datadir.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/datadir.py 644 /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree_nasty.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/timeouttest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/warntest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/failtest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/uncaught_exception.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/uncaught_exception.py 644 /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree.py.data/doublefree.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skiponsetup.py /usr/bin/env python
python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/skiponsetup.py 644 /usr/bin/env python
python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/output_check.sh.data/stderr.expected
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefail.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiplextest.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/raise.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/datadir.py.data/datadir.c
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/cabort.py.data/abort.c
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/linuxbuild.py /usr/bin/env python
python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptest.py /usr/bin/env python
python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/return99.c
3 packages and 0 specfiles checked; 37 errors, 11 warnings.



Requires
--------
python2-avocado-plugins-output-html (rpmlib, GLIBC filtered):
    pystache
    python(abi)
    python2-avocado

python-avocado-examples (rpmlib, GLIBC filtered):
    /bin/bash
    /bin/sh
    /usr/bin/env
    python-avocado

python2-avocado (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python2
    config(python2-avocado)
    fabric
    gdb
    gdb-gdbserver
    libvirt-python
    procps-ng
    pyliblzma
    pystache
    python
    python(abi)
    python-aexpect
    python-requests
    python-stevedore
    python-yaml



Provides
--------
python2-avocado-plugins-output-html:
    python-avocado-plugins-output-html
    python2-avocado-plugins-output-html
    python2.7dist(avocado-result-html)
    python2dist(avocado-result-html)

python-avocado-examples:
    python-avocado-examples
    python2-avocado-examples

python2-avocado:
    config(python2-avocado)
    python-avocado
    python2-avocado
    python2.7dist(avocado-framework)
    python2dist(avocado-framework)



Source checksums
----------------
https://github.com/avocado-framework/avocado/archive/43.0.tar.gz#/avocado-43.0.tar.gz :
  CHECKSUM(SHA256) this package     : 9c0bf4742968c1b67399ce79ca8d1efd422769220530614cf381866bbd51bc22
  CHECKSUM(SHA256) upstream package : 9c0bf4742968c1b67399ce79ca8d1efd422769220530614cf381866bbd51bc22


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1394952 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 6 Merlin Mathesius 2016-11-21 19:26:44 UTC 
Updated to (hopefully) address all review concerns.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-5.fc24.src.rpm
COPR build URLs: https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479689/ and (because fedora-rawhide-x86_64 build mysteriously failed on the first try) https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479690/
Comment 7 Stephen Gallagher 2016-11-21 20:05:49 UTC 
I have just a few remaining comments at this point:

- Please put a space after %config(noreplace), for readability. It looks like part of the path, which it is not.

- %config(noreplace)%{_sysconfdir}/avocado/conf.d/README, %config(noreplace) {_sysconfdir}/avocado/scripts/job/pre.d/README and %config(noreplace)%{_sysconfdir}/avocado/scripts/job/post.d/README should not be %config(noreplace). They shouldn't be edited by the end-user and as such we want changes to them clobbered on update.

- Are %config(noreplace)%{_sysconfdir}/avocado/sysinfo/commands, %config(noreplace)%{_sysconfdir}/avocado/sysinfo/files and %config(noreplace)%{_sysconfdir}/avocado/sysinfo/profilers supposed to be editable by the end-user? If they're not *really* config files, they should not be %config(noreplace) (also, it would be best if upstream moved them to /usr/share if they're truly supposed to be immutable).

- Please remove the executable bit from all python files in %doc.
Comment 8 Merlin Mathesius 2016-11-21 22:29:28 UTC 
Thank you for the additional detailed feedback.

According to description of the following commit in the upstream repository, it is intended that users can customize the %config files in %{_sysconfdir}/avocado/sysinfo:

    https://github.com/avocado-framework/avocado/commit/0a6dc703252cd2405b5251ecebfc545a587ef4c8

Updates have been made to address the rest of your review concerns.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-6.fc24.src.rpm
COPR build URL: https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479732/
Comment 9 Stephen Gallagher 2016-11-22 00:21:35 UTC 
OK, I think this looks good to go. Approved!
Comment 10 Gwyn Ciesla 2016-11-22 14:00:40 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-avocado
Comment 11 Fedora Update System 2016-11-23 14:51:47 UTC 
python-aexpect-1.2.0-3.20161110gitaca459d.fc25 python-avocado-43.0-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c7b80aa595
Comment 12 Fedora Update System 2016-11-23 15:06:05 UTC 
python-aexpect-1.2.0-3.20161110gitaca459d.fc24 python-avocado-43.0-6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2054c2c43c
Comment 13 Fedora Update System 2016-11-25 09:39:05 UTC 
python-aexpect-1.2.0-3.20161110gitaca459d.fc24, python-avocado-43.0-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2054c2c43c
Comment 14 Fedora Update System 2016-11-25 09:42:01 UTC 
python-aexpect-1.2.0-3.20161110gitaca459d.fc25, python-avocado-43.0-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c7b80aa595
Comment 15 Fedora Update System 2016-12-05 21:41:18 UTC 
python-aexpect-1.2.0-3.20161110gitaca459d.fc25, python-avocado-43.0-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 16 Fedora Update System 2016-12-06 10:25:14 UTC 
python-aexpect-1.2.0-3.20161110gitaca459d.fc24, python-avocado-43.0-6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.