Bug 1395121

Summary: Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-24 20:28:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1394820    

Description Paul Howarth 2016-11-15 08:36:19 UTC
Spec URL: https://pkgs.rpmfusion.org/cgit/free/perl-Crypt-IDEA.git/plain/perl-Crypt-IDEA.spec
SRPM URL: http://download1.rpmfusion.org/free/fedora/development/rawhide/Everything/source/SRPMS/p/perl-Crypt-IDEA-1.10-4.fc25.src.rpm

Description:
This perl extension is an implementation of the IDEA block cipher algorithm.
The module implements the Crypt::BlockCipher interface.

This implementation is copyright Systemics Ltd (http://www.systemics.com/).

Fedora Account System Username: pghmcfc

The IDEA patent has expired (https://bugzilla.redhat.com/show_bug.cgi?id=1394820#c3) and hence I would like to move the package from RPM Fusion into Fedora.

On import I would remove the sentence about the patent from %description in the spec.

Comment 1 Petr Pisar 2016-11-15 09:14:16 UTC
URL and Source0 addressed are usable. Ok.
Source archive is original (SHA-256: 33bd78c11924a0fc1ff3eedde94078cbbf6b6ca9ede046d2b2f561e9e9a72019). Ok.
License verified from COPYRIGHT.
XS code found, architecture specific package is Ok.
Summary verified from IDEA.pod. Ok.
Description is Ok.
The spec file contains EPEL-5 specific code. Ok.
Build-requires are Ok.
All tests pass. Ok.

$ rpmlint perl-Crypt-IDEA.spec ../SRPMS/perl-Crypt-IDEA-1.10-4.fc26.src.rpm ../RPMS/x86_64/perl-Crypt-IDEA-*
perl-Crypt-IDEA.src: W: spelling-error %description -l en_US BlockCipher -> Block Cipher, Block-cipher, Decipherable
perl-Crypt-IDEA.x86_64: W: spelling-error %description -l en_US BlockCipher -> Block Cipher, Block-cipher, Decipherable
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm 
drwxr-xr-x    2 root    root                        0 Nov 15 10:06 /usr/lib64/perl5/vendor_perl/Crypt
-rw-r--r--    1 root    root                     1320 Nov 15 10:06 /usr/lib64/perl5/vendor_perl/Crypt/IDEA.pm
-rw-r--r--    1 root    root                     1877 Dec  8  2005 /usr/lib64/perl5/vendor_perl/Crypt/IDEA.pod
drwxr-xr-x    2 root    root                        0 Nov 15 10:06 /usr/lib64/perl5/vendor_perl/auto/Crypt
drwxr-xr-x    2 root    root                        0 Nov 15 10:06 /usr/lib64/perl5/vendor_perl/auto/Crypt/IDEA
-rwxr-xr-x    1 root    root                    11328 Nov 15 10:06 /usr/lib64/perl5/vendor_perl/auto/Crypt/IDEA/IDEA.so
drwxr-xr-x    2 root    root                        0 Nov 15 10:06 /usr/share/doc/perl-Crypt-IDEA
-rw-r--r--    1 root    root                     1048 Jul 23  2013 /usr/share/doc/perl-Crypt-IDEA/changes
drwxr-xr-x    2 root    root                        0 Nov 15 10:06 /usr/share/licenses/perl-Crypt-IDEA
-rw-r--r--    1 root    root                     2460 Apr 21  2006 /usr/share/licenses/perl-Crypt-IDEA/COPYRIGHT
-rw-r--r--    1 root    root                     1943 Nov 15 10:06 /usr/share/man/man3/Crypt::IDEA.3pm.gz
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm | sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(DynaLoader)
      1 perl(Exporter)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm | sort -f | uniq -c
      1 perl(Crypt::IDEA) = 1.10
      1 perl(IDEA) = 1.10
      1 perl-Crypt-IDEA = 1.10-4.fc26
      1 perl-Crypt-IDEA(x86-64) = 1.10-4.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16460071). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2016-11-15 14:18:11 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Crypt-IDEA

Comment 3 Fedora Update System 2016-11-15 16:31:33 UTC
perl-Crypt-IDEA-1.10-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e85db2ba89

Comment 4 Fedora Update System 2016-11-15 16:31:43 UTC
perl-Crypt-IDEA-1.10-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4d6f56c103

Comment 5 Fedora Update System 2016-11-15 16:31:48 UTC
perl-Crypt-IDEA-1.10-5.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-49c2e0da1c

Comment 6 Fedora Update System 2016-11-15 16:31:53 UTC
perl-Crypt-IDEA-1.10-5.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-114b48bfab

Comment 7 Fedora Update System 2016-11-15 16:31:59 UTC
perl-Crypt-IDEA-1.10-5.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7925ac1d3c

Comment 8 Fedora Update System 2016-11-15 16:32:04 UTC
perl-Crypt-IDEA-1.10-5.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d1b6e9d1ee

Comment 9 Fedora Update System 2016-11-15 17:18:39 UTC
perl-Crypt-IDEA-1.10-5.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7925ac1d3c

Comment 10 Fedora Update System 2016-11-15 17:55:11 UTC
perl-Crypt-IDEA-1.10-5.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-49c2e0da1c

Comment 11 Fedora Update System 2016-11-15 23:46:11 UTC
perl-Crypt-IDEA-1.10-5.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-114b48bfab

Comment 12 Fedora Update System 2016-11-15 23:52:23 UTC
perl-Crypt-IDEA-1.10-5.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d1b6e9d1ee

Comment 13 Fedora Update System 2016-11-16 10:25:16 UTC
perl-Crypt-IDEA-1.10-5.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e85db2ba89

Comment 14 Fedora Update System 2016-11-16 20:24:42 UTC
perl-Crypt-IDEA-1.10-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4d6f56c103

Comment 15 Fedora Update System 2016-11-24 20:28:32 UTC
perl-Crypt-IDEA-1.10-5.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-11-25 07:22:45 UTC
perl-Crypt-IDEA-1.10-5.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-11-26 22:52:45 UTC
perl-Crypt-IDEA-1.10-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2016-12-01 15:20:28 UTC
perl-Crypt-IDEA-1.10-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2016-12-01 15:24:15 UTC
perl-Crypt-IDEA-1.10-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2016-12-02 00:17:26 UTC
perl-Crypt-IDEA-1.10-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.