Bug 1395135

Summary:	CVE-2016-4484 dracut: Incorrect error handling when checking password [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Adam Mariš <amaris>
Component:	dracut	Assignee:	dracut-maint-list
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	24	CC:	agk, dracut-maint-list, gmazyland, harald, jonathan, okozina, zbyszek
Target Milestone:	---	Keywords:	Security, SecurityTracking
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Release Note
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-15 18:10:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1395134

Description Adam Mariš 2016-11-15 09:14:07 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of Fedora.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

[bug automatically created by: add-tracking-bugs]

Comment 1 Adam Mariš 2016-11-15 09:14:12 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1395134,1395135

# Description of your update
notes=Security fix for CVE-2016-4484

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Milan Broz 2016-11-15 09:39:24 UTC

This is NOT bug in cryptsetup package.

The mentioned scripts are not part of the cryptsetup package, neither in fedora, nor upstream.

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-11-15 18:10:34 UTC

People who need to secure their system have to:
- add a BIOS password
- add a grub password
- add "rd.shell=0" to the kernel cmdline

Anaconda does add "rd.shell=0" to the kernel cmdline, if you setup the
bootloader with a password. To setup a bootloader with a password, kickstart must be used. In other words, the default installation is not safe from physical access at the bootloader level without additional steps listed above.
So this is not a bug, although the documentation could be more verbose certainly.

See also:
https://github.com/rhinstaller/anaconda/commit/89f4c56f317951a3f1beac94ac16c6b292ff0f61
https://harald.hoyer.xyz/2016/11/15/dracut-and-cve-2016-4484-cryptsetup-initrd-root-shell/