Bug 1395292

Summary: timelines don't display policy events
Product: Red Hat CloudForms Management Engine Reporter: Ievgen Zapolskyi <izapolsk>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Ievgen Zapolskyi <izapolsk>
Severity: high Docs Contact:
Priority: high    
Version: 5.7.0CC: cpelland, hkataria, jhardy, mpovolny, obarenbo
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Linux   
Whiteboard: ui:timeline
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1396245 (view as bug list) Environment:
Last Closed: 2017-06-12 17:48:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1396245    
Attachments:
Description Flags
contents of policy events table none

Description Ievgen Zapolskyi 2016-11-15 16:04:43 UTC
Created attachment 1220869 [details]
contents of policy events table

Description of problem:
Timelines for vm/provider don't show any events though there are some policy events in policy_events table for that vm/provider

Version-Release number of selected component (if applicable):
5.7.0.10

How reproducible:
100%

Steps to Reproduce:
1. Add some infra provider to cfme (I used vsphere55)
2. Find any unused vm or provision new one
3. Create a policy and policy profile which will do something when target vm's power state is changed to poweredOff or poweredOn.
4. Assign this policy profile to vm from step 2
5. Power Off and Power On that vm
6. check policy_events table for policy events
7. Open Timelines for that vm or provider
8. Setup Timelines to show all the policy events 

Actual results:
nothing is displayed

Expected results:
all expected policy events should be displayed

Comment 3 Harpreet Kataria 2016-11-15 21:32:04 UTC
https://github.com/ManageIQ/manageiq/pull/12664

Comment 4 CFME Bot 2016-11-16 19:41:39 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/dc23d5eee209098390bed4458d9e337b0ed5f79d

commit dc23d5eee209098390bed4458d9e337b0ed5f79d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Nov 15 16:15:20 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Nov 16 13:10:04 2016 -0500

    Fixed code to set categories correctly for policy timelines.
    
    When switching to Policy Timelines set categories and events under each category correctly, display events on timelines based on event_type columns of policy event records.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1395292

 app/controllers/application_controller/timelines.rb       | 12 +++++-------
 .../application_controller/timelines/options.rb           | 15 ++++-----------
 spec/controllers/application_controller/timelines_spec.rb | 15 +++++++++++++++
 3 files changed, 24 insertions(+), 18 deletions(-)

Comment 5 CFME Bot 2016-11-16 19:41:44 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/036eca1e55b26fd2a8ce92c0cc639c90d2df6a5a

commit 036eca1e55b26fd2a8ce92c0cc639c90d2df6a5a
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Nov 16 13:13:53 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Nov 16 13:57:10 2016 -0500

    Renamed mngt -> management & minor cleanup
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1395292

 app/controllers/application_controller/timelines.rb      | 16 +++++++---------
 .../application_controller/timelines/options.rb          | 12 ++++++------
 app/views/layouts/_tl_options.html.haml                  |  4 ++--
 3 files changed, 15 insertions(+), 17 deletions(-)

Comment 6 CFME Bot 2016-11-16 19:51:10 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/6292f6983ab4437620408dbeb872cfe26624880b

commit 6292f6983ab4437620408dbeb872cfe26624880b
Author:     Jason Frey <fryguy9>
AuthorDate: Wed Nov 16 14:38:08 2016 -0500
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Wed Nov 16 14:47:48 2016 -0500

    Merge pull request #12664 from h-kataria/policy_timelines_load_fix
    
    Fixed code to set categories correctly for policy timelines.
    (cherry picked from commit 5cc7c4abe99cae26c9df9321d3dc1f6f2e530950)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1395292

 .../application_controller/timelines.rb            | 24 ++++++++-----------
 .../application_controller/timelines/options.rb    | 27 ++++++++--------------
 app/views/layouts/_tl_options.html.haml            |  4 ++--
 .../application_controller/timelines_spec.rb       | 15 ++++++++++++
 4 files changed, 37 insertions(+), 33 deletions(-)