Bug 139538
| Summary: | ext3 online resize fails on bigendian hosts | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Stephen Tweedie <sct> |
| Component: | e2fsprogs | Assignee: | Stephen Tweedie <sct> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.0 | CC: | dhowells, jlaska, tburke, twoerner |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | powerpc | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2004-12-10 22:13:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 135947 | ||
| Bug Blocks: | 135876 | ||
|
Description
Stephen Tweedie
2004-11-16 16:40:48 UTC
I've got the ext2online bits fixed up. It now successfully performs online resize, but after unmounting leaves the filesystem in an inconsistent state, so there appear to be bugs remaining in the in-kernel portion of the resize on bigendian hosts. Note on checking in fixes for this issue --- I've fixed a number of byte-order problems in the userland tool, to the point where it appears to be running correctly. But until I have the entire userland + kernel toolset working perfectly for bigendian hosts, I will not be checking in any of these fixes to e2fsprogs. For now, it's far better for ext2online to complain immedately that it cannot find the filesystem superblock (due to byteswapped magic numbers) than for it to proceed but then invoke buggy kernel code and potentially corrupt the disk. Looks like I've got this one under control --- I just need to push fixed rpms through the build system and test them in place. I don't think any kernel patches will be needed. There's one other thing that turned up during testing, though --- ext2online was falling back to an older mechanism involving the app manually modifying the live fs if run on an ext2 volume. That fallback is a relic of previous ext2online work and needs to be disabled before online resize goes live. I'll do that as part of the same build. All fixes are checked in. I've placed provisional rpms up for testing at: http://people.redhat.com/sct/.private/e2fsprogs/ Source, and binaries for i386, x86_64, ppc/ppc64 and s390/s390x are all there. I've done basic testing on the final changes, including performing live resizes on ppc64 and forcing a full fsck before and after the resize, and everything looks OK so far. For safety, this final build of ext2online has two further one-line changes over and above the byte-ordering fixes. It: Disables fallback to the old-style online resize if the new resize ioctls are not present (old-style is untested and unsupported, and unlikely to be bigendian-safe) and Disables the write file descriptor used by that fallback path, as a failsafe in case it attempts to modify the fs that way --- that would be safe enough on ext2 but not on ext3. Final build is e2fsprogs-1.35-11.5, in the RHEL4 trees as of 20041210. |