Bug 1395385

Summary: No longer possible to set ssh_password on pxe_ssh driver
Product: Red Hat OpenStack Reporter: Jason Montleon <jmontleo>
Component: openstack-tripleo-commonAssignee: Dougal Matthews <dmatthew>
Status: CLOSED WONTFIX QA Contact: Alexander Chuzhoy <sasha>
Severity: medium Docs Contact:
Priority: high    
Version: 10.0 (Newton)CC: aschultz, jmatthew, mburns, slinaber
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-05-09 10:38:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jason Montleon 2016-11-15 21:16:56 UTC 
Description of problem:
In OSP 7 and 8 it was possible to set ssh_password for the ssh pxe driver. In OSP 10 it looks like a PR was changed which made a mapping of pm_password to ssh_key_content rather than ssh_password and making it impossible to set an ssh password.

QCI currently relies on being able to set ssh_password in order to instrospect nodes.

Version-Release number of selected component (if applicable):
openstack-tripleo-common-5.3.0-6.el7ost.noarch

How reproducible:
Always

Steps to Reproduce:
1. Set up QCI 1.1 
2. Start an OpenStack deployment
3. Try to introspect a node

Actual results:
Fail because it is impossible to set an ssh_password

Expected results:
It should be possible as before to set a ssh_password on the pxe ssh driver.

Additional info:
L123 'pm_password': 'ssh_key_contents'
rpm -q --whatprovides /usr/lib/python2.7/site-packages/tripleo_common/utils/nodes.py
openstack-tripleo-common-5.3.0-6.el7ost.noarch

Modiying this line to ssh_password and restarting mistral and ironic services returns the prior functionality.

I'd guess this is the PR that changed the behavior:
https://github.com/openstack/tripleo-common/commit/4bd594fa0ca222a2d8933fb5d80262ddb3823438
Comment 1 Dmitry Tantsur 2017-05-09 10:38:25 UTC 
Hi! Sorry for not getting enough attention to this bug. I'm not sure we ever intended to be able to set ssh_password (though you can definitely set it via ironic CLI). Also the SSH driver is being phased out in favor of IPMI + virtualbmc, so unfortunately we won't be able to fix this bug/RFE.