Bug 1395402

Summary: firewall-cmd --reload fails with "Error: dictionary changed size during iteration"
Product: [Fedora] Fedora Reporter: Andrew Parker <andy>
Component: firewalldAssignee: Thomas Woerner <twoerner>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: twoerner
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-03 09:38:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Andrew Parker 2016-11-15 22:22:56 UTC 
Description of problem:

Under certain circumstances running "firewall-cmd --reload" will return an error.

Version-Release number of selected component (if applicable):

firewalld-0.4.4.1-1.fc24.noarch

How reproducible:

Every time.

Steps to Reproduce:

firewall-cmd --reload
firewall-cmd --permanent --new-zone=a1
firewall-cmd --permanent --new-zone=a2
firewall-cmd --permanent --delete-zone=a1
firewall-cmd --reload
firewall-cmd --permanent --delete-zone=a2
firewall-cmd --reload

Actual results:

[root@leo base]# firewall-cmd --reload
success
[root@leo base]# firewall-cmd --permanent --new-zone=a1
success
[root@leo base]# firewall-cmd --permanent --new-zone=a2
success
[root@leo base]# firewall-cmd --permanent --delete-zone=a1
success
[root@leo base]# firewall-cmd --reload
success
[root@leo base]# firewall-cmd --permanent --delete-zone=a2
success
[root@leo base]# firewall-cmd --reload
Error: dictionary changed size during iteration

Additional info:

Also happens with 0.4.3.3-1.fc24 and 0.4.1.2-1-fc24
Comment 1 Andrew Parker 2016-11-15 22:35:36 UTC 
Fedora-Workstation-Live-x86_64-25_Beta-1.1.iso has the slightly older version 0.4.3.3-1.fc25.  That version too has the same problem, so this bug is for Fedora 25 too.
Comment 2 Thomas Woerner 2017-02-03 09:38:07 UTC 
This has been fixed upstream: https://github.com/t-woerner/firewalld/commit/b1880c8ae38eeb4e4ab66212113bf4cc36fc8bb9

The fix is already part of the latest 0.4.4 release and update packages.