Bug 1395861

Created attachment 1221378 [details]
Patch for rawhide

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16479221

thanks for the heads-up

a few notes/questions:

- I'd add that in Rawhide, not as an update for older releases, so I find the version `if` superfluous

- I don't think it is necessary to add provides (nothing depends on it, does it?)

also, there's non zero chance that there may be some other restricted plugin in the future so the provides would cause a conflict if the other package gets revived

- OTOH, adding obsoletes for the old version is probably a good idea so that dnf knows what to do on system upgrade

sounds sane?

p.s. I have quite some backlog after holidays, don't expect me to react quickly - but feel free to ping me if it takes too long (> week)

(In reply to Karel Volný from comment #2)
> - I'd add that in Rawhide, not as an update for older releases, so I find
> the version `if` superfluous

I recommend this for F25 as well, as mpg123 is already included therein and therefore there is no further reason for external repositories to continue to carry it.  Otherwise, the %if does make it easier to import this version update into F24 cleanly.
 
> - I don't think it is necessary to add provides (nothing depends on it, does
> it?)

It's part of providing a smooth upgrade path, following the similar change to audacious-plugins:

http://pkgs.fedoraproject.org/cgit/rpms/audacious-plugins.git/commit/?id=b582d9323b26ef5e42381add25251fcbb9c2a2dd

> also, there's non zero chance that there may be some other restricted plugin
> in the future so the provides would cause a conflict if the other package
> gets revived

That would have a newer version/release, which is why the Obsoletes and Provides should be (as they are here) versioned.

(In reply to Yaakov Selkowitz from comment #3)
> (In reply to Karel Volný from comment #2)
> > - I'd add that in Rawhide, not as an update for older releases, so I find
> > the version `if` superfluous
> 
> I recommend this for F25 as well, as mpg123 is already included therein and
> therefore there is no further reason for external repositories to continue
> to carry it.

this was discussed on that other repo's mailinglist - as it didn't make it into GA, it cannot be dropped from F25 ...

> Otherwise, the %if does make it easier to import this version
> update into F24 cleanly.

... of course, the update can depend on another update, but I find it unnecessary to make update just for this packaging change ... and if an update for F24/F25 will be released, we're already far past the branching points, so why to put into rawhide code that will never be used when I can adjust just the branches

> > - I don't think it is necessary to add provides (nothing depends on it, does
> > it?)
> 
> It's part of providing a smooth upgrade path, following the similar change
> to audacious-plugins:

hm, we even have a guideline for that:

https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

I've discussed this with DNF contributor and he said that it would be better to use fixed versions in this case

http://koji.fedoraproject.org/koji/taskinfo?taskID=16597861