Bug 1395870

We have tested (or attempted to test) bug like this when Spacewalk 2.6 was to be released. This is a clone of that bug to get it re-tested on Satellite 5.8.0. In some cases bug can be completely irrelevant (in such cases I suggest to close the bug as NOTABUG), in some cases it might be wise to take the bug as a note that something changed in a given area and we might want to sanity-test that area (and mark the bug as VERIFIED with "SanityOnly" keyword) and in some cases bug might be totally relevant to Satellite.



+++ This bug was initially created as a clone of Bug #1377841 +++

+++ This bug was initially created as a clone of Bug #1098141 +++

Description of problem:

If more than 500 entries are returned by the search engine (Advanced Search) then downloaded CSV does not include all of them. Very few entries are listed in the CSV file.

Some observations provided by customer: 

In the case of 1065 results on WebUI: Only 65 are returned in the csv.  
In the case of 1032 results on WebUI: Only 32 are returned in the csv.  
In the case of 1025 results on WebUI: Only 25 are returned in the csv.  
In the case of 999 results on WebUI: Only 499 are returned in the csv.  


Version-Release number of selected component (if applicable):

How reproducible:
Always when search results are more than 500.

Steps to Reproduce:
1. Systems -> Advanced Search  
2. Put the search string​in "Search For:" and select appropriate "Field to Search:" Eg: Search for: dhcp   Field to Search: Name/Description
3. If search results are more than 500, click on "Download CSV" 

Actual results:

On above reproducer where search result have 3261 entries, ​the downloaded CSV contain list of only 261 entries. 

Expected results:

All entries from search result should be available in the CSV file 

Additional info:

In the case of 1065 results on WebUI: Only 65 are returned in the csv.  
In the case of 1032 results on WebUI: Only 32 are returned in the csv.  
In the case of 1025 results on WebUI: Only 25 are returned in the csv.  
In the case of 999 results on WebUI: Only 499 are returned in the csv.  
In the case of 2624 results on WebUI: Only 124 are returned in the csv.

--- Additional comment from Eric Herget on 2016-09-20 14:52:35 EDT ---

In spacewalk.github, I submitted pull request # 459 so people have a chance to look at the changes before its committed to master branch.

--- Additional comment from Eric Herget on 2016-10-03 12:11:34 EDT ---

spacewalk.github:
7b2183163dc8a8bc926517e3efd17c3b097441a0

--- Additional comment from Eric Herget on 2016-10-05 10:22:16 EDT ---

Found and fixed an issue where new code did not behave like previous code.  When a query contains an "in clause" by an empty array is passed in as inClause, old code would return an empty DataResult object.  The new code was attempting to run the query without substituting for the inClause.  This fix causes an empty DataResult object to be returned, just as the old code did.

2 commits now (this one and one in comment 2)
spacewalk.github:
8808ba74f63014c37e630ee021192faec8af1327

--- Additional comment from Radovan Drazny on 2016-11-11 06:11:15 EST ---

Verified on spacewalk-java-2.6.47-1 using the reproducer from initial report using the reproducer from Bug #1098141. After performing an advanced search, returning more than 500 items, and downloading the cvs file, the file contains correct number of items.