Bug 1395876

Summary:	get_possible_orgs function never called?
Product:	Red Hat Satellite 5	Reporter:	Jan Hutař <jhutar>
Component:	Server	Assignee:	Tomáš Kašpárek <tkasparek>
Status:	CLOSED NOTABUG	QA Contact:	Lukáš Hellebrandt <lhellebr>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	580	CC:	galtukho, jdostal, lhellebr, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1357480	Environment:
Last Closed:	2017-05-22 07:00:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1357480
Bug Blocks:	1397178

Description Jan Hutař 2016-11-16 21:17:23 UTC

We have tested (or attempted to test) bug like this when Spacewalk 2.6 was to be released. This is a clone of that bug to get it re-tested on Satellite 5.8.0. In some cases bug can be completely irrelevant (in such cases I suggest to close the bug as NOTABUG), in some cases it might be wise to take the bug as a note that something changed in a given area and we might want to sanity-test that area (and mark the bug as VERIFIED with "SanityOnly" keyword) and in some cases bug might be totally relevant to Satellite.



+++ This bug was initially created as a clone of Bug #1357480 +++

I believe the function get_possible_orgs in backend/server/handlers/xmlrpc/registration.py is never called from clients. It used to be called by getPossibleOrgs function which has been removed by commit 867c6219d5ac1e722797f4846f5cbe32900f83a7. I can not find any other invocation of the function in the whole SW repo.

If I am right, I believe the function should be removed as it is not used by the supported clients.

--- Additional comment from Lukáš Hellebrandt on 2016-07-18 06:21 EDT ---



--- Additional comment from Jiří Dostál on 2016-07-18 09:26:16 EDT ---

spacewalk.git b7907dfe1d75d90d466b39a1e1b163b0a4ba5f35

--- Additional comment from Lukáš Hellebrandt on 2016-11-11 08:25:19 EST ---

Verified with SW nightly from 2016-11-11.

There is no getPossibleOrgs function in file /usr/share/rhn/server/handlers/xmlrpc/registration.py .
I also can not see any problem caused by its removal in automation.

Comment 1 Lukáš Hellebrandt 2016-11-25 11:43:13 UTC

Verified with sat5.8 compose from 2016-11-21.

Used the same steps as in SW.

Comment 3 Tomáš Kašpárek 2017-05-22 07:00:21 UTC

Commits were reverted because they caused a regression in BZ#1450496.