Bug 1396331

Summary:	Review Request: elfio - C++ library for reading and generating ELF files
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Igor Gnatenko <ignatenko>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---	Flags:	ignatenko: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-24 01:44:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Orion Poplawski 2016-11-18 04:18:42 UTC

Spec URL: https://www.cora.nwra.com/~orion/fedora/elfio.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/elfio-3.2-1.fc26.src.rpm
Description:
ELFIO is a small, header-only C++ library that provides a simple interface for
reading and generating files in ELF binary format.

It is used as a standalone library - it is not dependant on any other product
or project. Adhering to ISO C++, it compiles on a wide variety of
architectures and compilers.

While the library is easy to use, some basic knowledge of the ELF binary
format is required. Such Information can easily be found on the Web.

Fedora Account System Username: orion

Comment 1 Igor Gnatenko 2016-11-18 08:36:54 UTC

Some issues to fix, but in general looks good.

[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     http://downloads.sf.net/elfio/elfio-3.2.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags

elfio-devel.noarch: W: spelling-error %description -l en_US dependant -> dependent, defendant, depend ant
elfio-devel.noarch: E: zero-length /usr/share/doc/elfio-devel/ChangeLog
elfio-devel.noarch: E: zero-length /usr/share/doc/elfio-devel/NEWS
elfio.src: W: spelling-error %description -l en_US dependant -> dependent, defendant, depend ant

Missing BuildRequires: gcc-c++

make %{?_smp_mflags} -> %make_build

you could also run some "tests" in %check. Because elfdump is compiled anyway, just run it against, let's say %{_bindir}/make.

Comment 2 Orion Poplawski 2016-11-19 19:41:45 UTC

Thanks for the review.  Issues have been fixed.

* Sat Nov 19 2016 Orion Poplawski <orion.com> - 3.2-2
- Fix source url
- Add BR gcc-c++
- Add %%check
- Other cleanup

Comment 3 Gwyn Ciesla 2016-11-20 16:43:01 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/elfio

Comment 4 Orion Poplawski 2016-11-24 01:44:38 UTC

Checked in and built.  Thanks.