Bug 1396416

Summary: [ocp-on-osp] openshift-ansible playbook may run multiple times during update/create
Product: OpenShift Container Platform Reporter: Jan Provaznik <jprovazn>
Component: Reference ArchitectureAssignee: scollier
Status: CLOSED NOTABUG QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: aos-scalability-34
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-27 20:06:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jan Provaznik 2016-11-18 09:32:36 UTC
Description of problem:
Openshift compute ndoes are members of AutoscalingGroup in heat stack, when each member is created it registers itself on bastion node ("deployment_bastion_node_add" SW deployment in templates), then a separate step ("deployment_run_ansible" in node.yaml) configures openshift on all nodes which are already registered.

It may happen that deployment_run_ansible is trigerred by some node before all nodes are registered (by deployment_bastion_node_add) which causes that then nodes are added in multiple ansible runs/batches. It doesn't break setup and basically is nothing bad with it but it makes creation or scale up slower. It would be better to wait until deployment_bastion_node_add is done for all nodes and then run deployment_run_ansible only once for all nodes (AutoscalingGroup doesn't allow to do this easily though).

Version-Release number of selected component (if applicable):
openshift-on-openstak 0.9.5

How reproducible:
it's random but can be reproduced when deploying with any higher number of nodes (e.g. node_count=5)

Comment 1 Jan Provaznik 2016-11-18 09:50:54 UTC
Addressed by:
https://github.com/redhat-openstack/openshift-on-openstack/pull/302

Comment 2 Jan Provaznik 2016-11-18 11:47:53 UTC
For  aos-scalability-34 testing the patch above was applied.

Comment 3 Jan Provaznik 2016-12-13 08:28:21 UTC
Hi, the patch for this issue is not a one-liner, I'm concerned about regression it might introduce. This issue is only optimization (deployment will work without this patch too, it will just be slower which matters only for larger deployments), do you really want to include this now instead of in the next release?