Bug 1396583

Summary: Service dialogs items(tabs/boxes/elements) can be saved even when it doesn't fulfill requirements
Product: Red Hat CloudForms Management Engine Reporter: Matouš Mojžíš <mmojzis>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Satyajit Bulage <sbulage>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7.0CC: hkataria, jhardy, mpovolny, obarenbo, sbulage, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1413103 (view as bug list) Environment:
Last Closed: 2017-06-12 17:41:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1413103    

Description Matouš Mojžíš 2016-11-18 16:31:12 UTC 
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Go to Automate -> Customization -> Service dialogs
2. Create a new dialog
3. Add a new tab to this dialog (It tells that tab has to have at least one box)
4. In toolbar select add a new tab to this dialog

Actual results:
It saves previous tab even when it has no boxes. Works same for boxes/elements etc.

Expected results:
It shouldn't allow adding another tabs when creating of one is in progress.

Additional info:
Comment 4 CFME Bot 2017-01-06 19:07:05 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/91
Comment 5 CFME Bot 2017-01-06 22:07:12 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/7e168841d2e19bb6684d63ca492d6f63c13326e9

commit 7e168841d2e19bb6684d63ca492d6f63c13326e9
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jan 6 09:16:12 2017 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Jan 6 14:46:41 2017 -0500

    Validate dialog children while edit is in progress
    
    Validate dialog children when adding another one of same type of elements/tab/box to same parent. When adding a new tab/box/element to same parent validate if the one being added/edited already has children before adding a new empty one. Previously this validation was only done at ehe end when Add/Save buttons were pressed.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1396583

 .../miq_ae_customization_controller/dialogs.rb     | 17 +++++--
 .../dialogs_spec.rb                                | 57 ++++++++++++++++++++++
 2 files changed, 70 insertions(+), 4 deletions(-)
Comment 7 Satyajit Bulage 2017-04-28 07:50:30 UTC 
It is not allowing to add another tab when creating of one is in progress.

Verified Version:  5.8.0.12-rc1.20170425180304_4f35996