Bug 1396601

Summary: Incompatibility with erfa 1.3.0
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: python-astropyAssignee: Sergio Pascual <sergio.pasra>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: sergio.pasra
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-astropy-1.2.1-5.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-22 20:07:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
spec
none
spec
none
spec none

Description Orion Poplawski 2016-11-18 18:07:43 UTC
Created attachment 1221930 [details]
spec

Description of problem:

With the system erfa 1.3.0, test_sidereal fails:

_____________ ERROR collecting astropy/time/tests/test_sidereal.py _____________
astropy/time/tests/test_sidereal.py:24: in <module>
    class TestERFATestCases():
astropy/time/tests/test_sidereal.py:34: in TestERFATestCases
    assert np.allclose(time_ut1.tt.jd2 - time_tt.jd2, 0., atol=1.e-14)
E   assert False
E    +  where False = <function allclose at 0xf4fce80c>((-0.4999999999999999 - 0.5), 0.0, atol=1e-14)
E    +    where <function allclose at 0xf4fce80c> = np.allclose
E    +    and   -0.4999999999999999 = <Time object: scale='tt' format='jd' value=2453735.5>.jd2
E    +      where <Time object: scale='tt' format='jd' value=2453735.5> = <Time object: scale='ut1' format='jd' value=2453736.5>.tt
E    +    and   0.5 = <Time object: scale='tt' format='jd' value=2453736.5>.jd2

See https://github.com/astropy/astropy/pull/5466 for more details.

I'm proposing we build with the bundled erfa for now until this is resolved.

I'd also like to build with the bundled wcslib on EPEL.  See attached spec for details.  Although we do have an issue with an old scipy in EPEL at the moment.

Version-Release number of selected component (if applicable):
1.2.1-4.fc26

Comment 1 Orion Poplawski 2016-11-18 18:43:27 UTC
Created attachment 1221968 [details]
spec

Fix conditional

Comment 3 Sergio Pascual 2016-11-21 22:40:21 UTC
What version of erfa do you need in epel?

Comment 4 Orion Poplawski 2016-11-21 22:50:22 UTC
Current erfa is fine in EPEL.  But with erfa 1.3.0, I think we should build with bundled erfa.

scipy is blocking updating astropy in EPEL though.

If you're okay with proposed spec I'll check that into master as build.

Comment 5 Sergio Pascual 2016-11-21 22:58:04 UTC
You have uploaded a different spec, protobuf?

Comment 6 Orion Poplawski 2016-11-21 23:13:26 UTC
Created attachment 1222497 [details]
spec

Ah, trying to do too many things at once again.  How about this?

Comment 7 Sergio Pascual 2016-11-21 23:27:42 UTC
Fantastic, please go ahead and thank you

Comment 8 Orion Poplawski 2016-11-22 20:07:09 UTC
ppc64 builds are still unstable unfortunately (due to bug #1394975), but managed to get a build to complete.