| Summary: | Review Request: golang-github-knieriem-markdown - A translation of peg-markdown into Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Rosser <rosser.bjr> |
| Component: | Package Review | Assignee: | gil cattaneo <puntogil> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, puntogil |
| Target Milestone: | --- | Flags: | puntogil:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-09 22:25:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Ben Rosser
2016-11-18 19:11:55 UTC
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1396216 ? thanks in advance Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "MIT/X11 (BSD like) GPL (v2 or later)", "Unknown or
generated". 9 files have unknown license. Detailed output of
licensecheck in /home/gil/1396636-golang-github-knieriem-
markdown/licensecheck.txt
The following source files are without license headers:
markdown-325ec6c40dd46f6b39ddfd2e3021697a726894bb/cmd/markdown/main.go
markdown-325ec6c40dd46f6b39ddfd2e3021697a726894bb/cmd/markdown/pprof.go
markdown-325ec6c40dd46f6b39ddfd2e3021697a726894bb/doc.go
markdown-325ec6c40dd46f6b39ddfd2e3021697a726894bb/elemheap.go
Please, ask to upstream to confirm the licensing of code and/or content/s,
and add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification
[x]: License file installed when any subpackage combination is installed.
[?]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[?]: Package requires other packages for directories it uses.
Note: No known owner of
/usr/share/gocode/src/github.com/knieriem/markdown/cmd
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode/src/github.com/knieriem/markdown/cmd,
/usr/share/gocode, /usr/share/gocode/src/github.com
[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-knieriem-markdown-devel , golang-github-knieriem-markdown-unit-
test-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: golang-github-knieriem-markdown-devel-0-1.git325ec6c.fc26.noarch.rpm
golang-github-knieriem-markdown-unit-test-devel-0-1.git325ec6c.fc26.i686.rpm
golang-github-knieriem-markdown-0-1.git325ec6c.fc26.src.rpm
golang-github-knieriem-markdown.src: W: spelling-error %description -l en_US groff -> gruff, gr off, gr-off
golang-github-knieriem-markdown.src:65: W: macro-in-comment %endif
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages)
----------------------------
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires
--------
golang-github-knieriem-markdown-unit-test-devel (rpmlib, GLIBC filtered):
golang-github-knieriem-markdown-devel
golang-github-knieriem-markdown-devel (rpmlib, GLIBC filtered):
Provides
--------
golang-github-knieriem-markdown-unit-test-devel:
golang-github-knieriem-markdown-unit-test-devel
golang-github-knieriem-markdown-unit-test-devel(x86-32)
golang-github-knieriem-markdown-devel:
golang(github.com/knieriem/markdown)
golang-github-knieriem-markdown-devel
Source checksums
----------------
https://github.com/knieriem/markdown/archive/325ec6c40dd46f6b39ddfd2e3021697a726894bb/markdown-325ec6c.tar.gz :
CHECKSUM(SHA256) this package : 307a887e44985ca35f70d1491d8075ceae356268ece92f0b85f36ef887f23ebc
CHECKSUM(SHA256) upstream package : 307a887e44985ca35f70d1491d8075ceae356268ece92f0b85f36ef887f23ebc
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1396636 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Opened this ticket upstream asking for license clarification: https://github.com/knieriem/markdown/issues/14 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-knieriem-markdown golang-github-knieriem-markdown-0-1.git325ec6c.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-aca5a759b9 golang-github-knieriem-markdown-0-1.git325ec6c.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba6715cd7f golang-github-knieriem-markdown-0-1.git325ec6c.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-fc4294ee35 golang-github-knieriem-markdown-0-1.git325ec6c.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-fc4294ee35 golang-github-knieriem-markdown-0-1.git325ec6c.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba6715cd7f golang-github-knieriem-markdown-0-1.git325ec6c.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aca5a759b9 golang-github-knieriem-markdown-0-1.git325ec6c.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. golang-github-knieriem-markdown-0-1.git325ec6c.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. golang-github-knieriem-markdown-0-1.git325ec6c.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |