Bug 1396790
| Summary: | Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature, voltage, and fan speed | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Audrey Yeena Toskin <audrey> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 25 | CC: | audrey, mail, package-review, zbyszek |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
| Hardware: | noarch | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-01 17:25:03 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Audrey Yeena Toskin
2016-11-20 07:15:27 UTC
$ wget https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec --2016-11-21 08:01:50-- https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec Resolving gitlab.com (gitlab.com)... 104.210.2.228 Connecting to gitlab.com (gitlab.com)|104.210.2.228|:443... connected. HTTP request sent, awaiting response... 404 Not Found 2016-11-21 08:01:51 ERROR 404: Not Found. Sorry, I'd accidentally set the project permissions to private instead of public. Should work now. Please run fedora-review on this package. It flags quite a few issues. Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-freon-22-1.fc25.src.rpm Updated to upstream version 23. Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-freon-23-1.fc25.src.rpm Like one or a couple of my other pending review requests, one remaining issue from fedora-review says something about gschemas, but I don't entirely understand what it's trying to tell me to do:
Issues:
=======
- glib-compile-schemas is run in %postun and %posttrans if package has
*.gschema.xml files.
Note: gschema file(s) in gnome-shell-extension-freon
See:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema
I was thinking for a moment that maybe it's trying to say that I shouldn't run `glib-compile-schemas` myself, because it's automatically part of the %posttrans process? But the spec does not actually compile *anything*, and there's no Makefile. * Better locale detection, files moved to system directory. * Moved gschema file to system directory. * Demoted GNOME Tweak Tool from a Require to a Recommend. Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-freon-23-1.fc26.src.rpm If you look at the scriptlet description (http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema), you'll see that this is only for Fedora <= 23. So that fedora-review advice is obsolete, in current Fedora versions there's nothing to do, and compilation is done through file triggers provided by some other package. + latest version + builds and installs and runs OK + license is acceptable (GPLv2) + license is specified correctly + package name is OK + no scriptlets needed + BR/R/P look correct Package is APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-freon gnome-shell-extension-freon-23-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e00c7f74b8 gnome-shell-extension-freon-23-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-611188e1d5 gnome-shell-extension-freon-23-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc08e27adc gnome-shell-extension-freon-23-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e00c7f74b8 gnome-shell-extension-freon-23-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc08e27adc gnome-shell-extension-freon-23-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-611188e1d5 gnome-shell-extension-freon-23-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-13296bd01c gnome-shell-extension-freon-23-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6e4022c6bf gnome-shell-extension-freon-23-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f2d129a325 gnome-shell-extension-freon-23-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8da66111c gnome-shell-extension-freon-23-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8da66111c gnome-shell-extension-freon-23-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-freon-23-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f2d129a325 gnome-shell-extension-freon-23-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-13296bd01c gnome-shell-extension-freon-23-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6e4022c6bf gnome-shell-extension-freon-23-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2486ed920e gnome-shell-extension-freon-23-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e726bb2298 gnome-shell-extension-freon-23-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cb3cb1f22d gnome-shell-extension-freon-23-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-021e8661c5 gnome-shell-extension-freon-23-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e726bb2298 gnome-shell-extension-freon-23-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cb3cb1f22d gnome-shell-extension-freon-23-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2486ed920e gnome-shell-extension-freon-23-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-021e8661c5 gnome-shell-extension-freon-23-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1c4da7f3ce gnome-shell-extension-freon-23-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-72c489ec6f gnome-shell-extension-freon-23-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-26d9463a92 gnome-shell-extension-freon-23-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a336c1fef3 gnome-shell-extension-freon-23-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-26d9463a92 gnome-shell-extension-freon-23-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-72c489ec6f gnome-shell-extension-freon-23-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1c4da7f3ce gnome-shell-extension-freon-23-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a336c1fef3 gnome-shell-extension-freon-23-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-freon-23-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-freon-23-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-freon-23-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-freon-23-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |