Bug 1396847 (screencloud)
| Summary: | Review Request: screencloud - Easy to use screenshot sharing application | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | didiksupriadi41, igor.raits, package-review, tomas.korb | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2021-08-21 15:51:54 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1394149, 1396846 | ||||||
| Bug Blocks: | 201449 | ||||||
| Attachments: |
|
||||||
|
Description
Igor Gnatenko
2016-11-20 21:47:14 UTC
Created attachment 1236717 [details]
Patch for unbundling qtsingleapplication
I'd justify bundling libqxt quoting upstream:
"
LIBQXT IS NO LONGER MAINTAINED
Qxt will likely not work with newer Qt versions due to usage of internal api. We recommend that you pick out the parts you want instead of using the entire libqxt.
"
Patch for unbundling qtsingleapplication attached.
Hi Igor, any update here? (In reply to Sandro Mani from comment #2) > Hi Igor, any update here? Hey, give me couple of days. Busy =( No worries, just asking ;) Hello, According to the fedora-review you dont have to list "gcc" and "make" in BuildRequires, i compiled the code after removal and it works so i think you can remove it. Upstream already accepted change of desktop file and removed execution permission from LICENSE and README.md so you can remove that parts too. And if you would have some time you could also look at the unbundling. (In reply to Tomáš Korbař from comment #5) > Hello, > According to the fedora-review you dont have to list "gcc" and "make" in > BuildRequires, i compiled the code after removal and it works so i think you > can remove it. > Upstream already accepted change of desktop file and removed execution > permission from LICENSE and README.md so you can remove that parts too. Bad luck, fedora-review. Guidelines say to explicitly mention everything. (In reply to Tomáš Korbař from comment #6) > And if you would have some time you could also look at the unbundling. I tried to, but I failed (at least on libxqt), and qtsingleapplication failed too because they patch code. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. Seems like the submitter account is disabled (?), please make sure you have added the correct RHBZ (Red Hat Bugzilla) email. I will be closing this package review if there is no response in a week. |