Bug 1396922

Summary:	Review Request: python-yarl - A Python module to handle URLs
Product:	[Fedora] Fedora	Reporter:	Fabian Affolter <mail>
Component:	Package Review	Assignee:	Igor Gnatenko <ignatenko>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	athmanem, mail, package-review
Target Milestone:	---	Flags:	ignatenko: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-11 19:32:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabian Affolter 2016-11-21 08:37:26 UTC

Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl-0.7.1-1.fc24.src.rpm

Project URL: http://pythonhosted.org/yarl/

Description:
The module provides handy URL class for url parsing and changing.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16551043

rpmlint output:
[fab@laptop016 SRPMS]$ rpmlint python-yarl-0.7.1-1.fc24.src.rpm 
python-yarl.src: W: spelling-error %description -l en_US url -> URL, curl, purl
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[fab@laptop016 x86_64]$ rpmlint python*-yarl-*
python3-yarl.x86_64: W: spelling-error %description -l en_US url -> URL, curl, purl
python3-yarl.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.5/site-packages/yarl/_quoting.c
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab

Comment 1 Igor Gnatenko 2016-11-21 08:57:41 UTC

* No need for "A" in summary, it's making it more unreadable
* It's better to take archive out of GitHub, not from PyPI (especially when it comes down to Cython, why checks if it uses Cython to generate code or uses pre-generated code)
* python3-yarl.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.5/site-packages/yarl/_quoting.c -> please report bug to upstream and make note in spec
* Tests are not executed, but present
* %{python3_sitearch}/%{srcname}*.egg-info -> %{python3_sitearch}/%{srcname}-*.egg-info/ (trailing slash is needed for RPM to not accept files, disutils uses file, setuptools uses directory)

ALMOST GOOD.

Comment 2 Fabian Affolter 2016-11-22 13:52:37 UTC

*** Bug 1396923 has been marked as a duplicate of this bug. ***

Comment 3 Igor Gnatenko 2017-01-01 15:17:48 UTC

ping?

Comment 4 Fabian Affolter 2017-01-21 12:20:56 UTC

Sorry for the delay and thanks for the remarks.

Comment 5 Fabian Affolter 2017-01-21 13:05:17 UTC

* Sat Jan 21 2017 Fabian Affolter <mail> - 0.8.1-1
- Update to latest upstream release 0.8.1
- Remove _quoting.c

* Mon Nov 21 2016 Fabian Affolter <mail> - 0.7.1-2
- Update Source0, summary

Updated files: 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl-0.8.1-1.fc24.src.rpm

Comment 6 Igor Gnatenko 2017-01-21 13:10:43 UTC

Would be nice to get comment why tests are commented out in spec. No other issues.

P.S. would be happy if you will add me as co-maintainer

Comment 7 Gwyn Ciesla 2017-01-23 14:10:01 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-yarl