Bug 1397035

Summary: Add 'is empty' & 'is not empty' match types.
Product: [Community] Bugzilla Reporter: Romana Cadova <rcadova>
Component: Internal ToolsAssignee: Matt Tyson 🤬 <mtyson>
Internal Tools sub component: Rules Engine QA Contact: tools-bugs <tools-bugs>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: unspecified    
Priority: unspecified CC: huiwang, lsmid, mtyson, qgong, rcadova, tlavigne, yijli, ylavi
Version: 4.4   
Target Milestone: 4.4   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-30 01:00:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1406266    
Bug Blocks:    

Description Romana Cadova 2016-11-21 12:59:04 UTC
Getting:

field	value
cf_conditional_nak	Hardware Upstream Capacity Patch Design Reproducer


when creating clear_devel_conditional_nak rule in BRE.
https://partner-bugzilla.redhat.com/page.cgi?id=ruleengine/details/index.html&rule_name=clear_devel_conditional_nak

In step2 I set the condition:

Devel Conditional NAK is any of - and here I would need to check everything

also tried with "contains any of the strings" "Hardware, Upstream, ..."

In step3 I set:

Devel Conditional NAK - remove - check everything

also tried with
- unset- in step3

I was able to save this rule only with "Hardware" checked.

What am I doing wrong?
The same happens in prod bz too.

Thank you.

Comment 1 Matt Tyson 🤬 2016-11-23 04:13:37 UTC
The fix here is to add a new custom field match type

'is empty'
'is not empty'

This way you can create a new match type

'Devel Conditional NAK' 'is not empty'

On page three, you should be selecting 'Unset'.  A bug in the recursive action checker was causing this not to work.

Comment 2 Rony Gong 🔥 2016-12-20 09:16:24 UTC
'is empty'
'is not empty'
Added, and waiting for bug 1406266 to be fixed

Comment 3 Rony Gong 🔥 2016-12-21 04:24:41 UTC
Tested on QA environment(5.0.3-rh20)
Result: Pass
It works now.

Comment 4 Rony Gong 🔥 2017-01-09 09:37:03 UTC
Tested on QA environment(4.4.12065-1.el6)
Result: Pass
It works now.

Comment 5 Jeff Fearn 🐞 2017-01-15 22:31:13 UTC
*** Bug 1413383 has been marked as a duplicate of this bug. ***

Comment 6 Matt Tyson 🤬 2017-01-30 01:00:45 UTC
This change is now live. If there are any issues, do not reopen this bug.                                                                                                           
Instead, you should create a new bug and reference this bug.