Bug 1397088

Summary:	OVN provider does not change OVN lswitch names after changing OVN network names
Product:	[oVirt] ovirt-engine	Reporter:	Mor <mkalfon>
Component:	BLL.Network	Assignee:	Marcin Mirecki <mmirecki>
Status:	CLOSED WONTFIX	QA Contact:	Meni Yakove <myakove>
Severity:	medium	Docs Contact:
Priority:	low
Version:	future	CC:	bugs, danken, mmirecki, ylavi
Target Milestone:	---	Flags:	sbonazzo: ovirt-4.2-
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-16 15:16:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Mor 2016-11-21 15:11:13 UTC

Description of problem:
Currently with the OVN feature, we represent OVN networks entities as OVN switches. When changing the name of OVN network in oVirt UI, the provider does not trigger a change to the OVN switch names in the north DB. Since admins usually use names to locate switch/network names using OVN CLI tools, it will be nicer to have consistent names.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create network on OVN network provider.
2. Change OVN network name in oVirt.
3. "ovn-nbtctl show" on the Central OVN server.

Actual results:
Network name remains the same before the change.

Expected results:
oVirt network names should reflect OVN switch names.

Additional info:

Comment 1 Dan Kenigsberg 2016-11-22 08:52:02 UTC

I understand the debuggability benefit, but frankly, I think that propagating the human-readable name outside of Engine is the bug. Simply because it is hard to maintain in-sync.

Marcin, beside its help to debuggability, can we avoid usage of the name in the provider and driver?

Comment 2 Mor 2016-11-22 14:33:10 UTC

Quote from OVN User Manual (http://openvswitch.org/support/dist-docs/ovn-nbctl.8.html):
"The OVN northbound database schema does not require logical switch names to be unique, but the whole point to the names is to provide an easy way for humans to refer to the switches, making duplicate names unhelpful. Thus, without any options, this command regards it as an error if switch is a duplicate name."

Comment 3 Mor 2016-11-22 14:45:08 UTC

Sorry its related(In reply to Mor from comment #2)
> Quote from OVN User Manual
> (http://openvswitch.org/support/dist-docs/ovn-nbctl.8.html):
> "The OVN northbound database schema does not require logical switch names to
> be unique, but the whole point to the names is to provide an easy way for
> humans to refer to the switches, making duplicate names unhelpful. Thus,
> without any options, this command regards it as an error if switch is a
> duplicate name."

Ignore this please, it's relevant for the duplicate names issue.

Comment 4 Marcin Mirecki 2017-06-09 08:18:05 UTC

To be consistant with the neturon API, we have to provide the name of the network, so it has to stay in.
We could store the name as an additional property (OVN logical switch 'external-id' table), but don't like the idea.

The actual problem lies in the engine, which does not notify the provider that the name was changed.

Comment 5 Dan Kenigsberg 2017-07-16 15:16:48 UTC

Our expected mode of operation is to modify network names in OVN (via ManageIQ) so that this problem is less important.