Bug 1397098

Summary:	Upgrade python-requests to 2.11.1 for Newton
Product:	[Community] RDO	Reporter:	Michal Pryc <mpryc>
Component:	distribution	Assignee:	Alan Pevec <apevec>
Status:	CLOSED ERRATA	QA Contact:	Shai Revivo <srevivo>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	trunk	CC:	apevec, chris.brown, markmc, srevivo
Target Milestone:	---
Target Release:	trunk
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1397099 (view as bug list)		Environment:
Last Closed:	2017-06-22 15:51:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1397099

Description Michal Pryc 2016-11-21 15:40:08 UTC

Description of problem:

Currently python-requests 2.10.0 package is available, however 2.11.0 should be as in upper-constraints:

https://github.com/openstack/requirements/blob/stable/newton/upper-constraints.txt#L328

Without this package at least python-novaclient unit test fails:
novaclient.tests.unit.test_client.ClientTest.test_client_with_timeout
---------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "novaclient/tests/unit/test_client.py", line 60, in test_client_with_timeout
        instance.authenticate()
      File "novaclient/client.py", line 612, in authenticate
        auth_url = self._v1_auth(auth_url)
      File "novaclient/client.py", line 648, in _v1_auth
        resp, body = self._time_request(url, 'GET', headers=headers)
      File "novaclient/client.py", line 431, in _time_request
        resp, body = self.request(url, method, **kwargs)
      File "novaclient/client.py", line 404, in request
        if resp.text:
      File "/home/migi/Desktop/Development/Upstream/python-novaclient/.tox/py27/lib/python2.7/site-packages/requests/models.py", line 796, in text
        if not self.content:
      File "/home/migi/Desktop/Development/Upstream/python-novaclient/.tox/py27/lib/python2.7/site-packages/requests/models.py", line 772, in content
        self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
      File "/home/migi/Desktop/Development/Upstream/python-novaclient/.tox/py27/lib/python2.7/site-packages/requests/models.py", line 705, in generate
        chunk = self.raw.read(chunk_size)
    AttributeError: 'NoneType' object has no attribute 'read'

Comment 1 Michal Pryc 2016-11-21 15:50:30 UTC

Version should be 2.11.1 as in upper-constraints (not as I wrote in previous comment 2.11.0).

Comment 2 Alan Pevec 2016-12-21 22:55:44 UTC

python-requests-2.11.1-1.el7 python-urllib3-1.16-1.el7 built in CBS Koji and available for testing in common-pending CBS repository:
http://cbs.centos.org/repos/cloud7-openstack-common-pending/x86_64/os/

Comment 3 Christopher Brown 2017-06-22 15:51:31 UTC

This was upgraded, closing.