| Summary: | expansion of macro in %autosetup | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | rpm | Assignee: | Packaging Maintenance Team <packaging-team-maint> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ignatenko, kardos.lubos, novyjindrich, packaging-team-maint, pknirsch, pmatilai |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-16 14:02:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
with %setup -q %{?rev:-c} it works fine.
IIRC this is "by design" for parameterized macros like %autosetup, %setup is not a macro even if it looks like one... (In reply to Panu Matilainen from comment #2) > IIRC this is "by design" for parameterized macros like %autosetup, %setup is > not a macro even if it looks like one... Okay, but I think it's bug. We should expand such conditionals everywhere. This is an upstream issue, lets move the discussion there: https://github.com/rpm-software-management/rpm/issues/127 I'm tempted to CLOSE -> UPSTREAM but we can keep this open for Fedora tracking if you like. FWIW, fixed upstream now at https://github.com/rpm-software-management/rpm/commit/5adc56897b9da5dac49701f704ef54390db57c59 Lets see what breaks ;) |
%global rev 133 ... %autosetup %{?rev:-c} ... but it doesn't really do `-c`. If I remove macro (%autosetup -c) it starts working