Bug 1397282

Summary: dmesg: "trying to register non-static key, the code is fine but needs lockdep annotation."
Product: [Fedora] Fedora Reporter: Michael <mdunphy>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 24CC: ahipp0, cz172638, gansalmon, ichavero, itamar, jonathan, kernel-maint, madhu.chinakonda, mchehab
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-08 19:19:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Michael 2016-11-22 07:07:36 UTC
Description of problem:

The message below appeared in my dmesg output. It did not lock the kernel, ie, it's not a severe problem, but it appears to be a bug... so I'm reporting it anyway in the event that it leads to a bugfix.

Version-Release number of selected component (if applicable):

Linux magrathea 4.8.8-200.fc24.x86_64+debug #1 SMP Tue Nov 15 19:14:59 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

How reproducible:

I haven't been able to reproduce it yet. That said, it occurred under the following somewhat-unusual conditions:

1) I initiated a move of three 175MB files from a SSD to a HDD. The transfer "froze" at the beginning -- listing the destination dir showed that 262144 bytes were written.
2) While waiting for the transfer, I mounted a cifs share
3) I checked dmesg to see if there was any info as to why 1) was stalled, and saw the message below
4) The transfer "unstalled" after about 3 minutes of delay and then completed in a few seconds

Lastly, I'm not a kernel dev, but it seems plausible that the "stalled" transfer was using a lock in a fashion that didn't play well with cifs.

Actual results:

This message appears in the output from 'dmesg':

[ 7978.831066] FS-Cache: Loaded
[ 7978.833523] Key type dns_resolver registered
[ 7978.861343] FS-Cache: Netfs 'cifs' registered for caching
[ 7978.862167] Key type cifs.spnego registered
[ 7978.862173] Key type cifs.idmap registered
[ 8066.332188] INFO: trying to register non-static key.
[ 8066.332192] the code is fine but needs lockdep annotation.
[ 8066.332193] turning off the locking correctness validator.
[ 8066.332195] CPU: 5 PID: 6500 Comm: bash Not tainted 4.8.8-200.fc24.x86_64+debug #1
[ 8066.332196] Hardware name: ASUS All Series/SABERTOOTH Z87, BIOS 1007 05/17/2013
[ 8066.332197]  0000000000000086 00000000d446b95a ffff913128793c40 ffffffff9c465f13
[ 8066.332200]  0000000000000000 0000000000000000 ffff913128793cb0 ffffffff9c10b71d
[ 8066.332202]  ffff9132740e4000 0000000000000001 ffff913128793c70 ffff9132740e4928
[ 8066.332204] Call Trace:
[ 8066.332207]  [<ffffffff9c465f13>] dump_stack+0x86/0xc3
[ 8066.332210]  [<ffffffff9c10b71d>] register_lock_class+0x50d/0x520
[ 8066.332212]  [<ffffffff9c10e8f2>] __lock_acquire+0x92/0x1290
[ 8066.332214]  [<ffffffff9c037e79>] ? sched_clock+0x9/0x10
[ 8066.332216]  [<ffffffff9c0ea4c7>] ? sched_clock_cpu+0xa7/0xc0
[ 8066.332230]  [<ffffffffc07f6507>] ? _get_xid+0x67/0xa0 [cifs]
[ 8066.332232]  [<ffffffff9c10ff56>] lock_acquire+0xf6/0x1f0
[ 8066.332239]  [<ffffffffc07e9ce9>] ? cifs_closedir+0x79/0x3b0 [cifs]
[ 8066.332241]  [<ffffffff9c8f5f8d>] _raw_spin_lock+0x3d/0x80
[ 8066.332248]  [<ffffffffc07e9ce9>] ? cifs_closedir+0x79/0x3b0 [cifs]
[ 8066.332254]  [<ffffffffc07e9ce9>] cifs_closedir+0x79/0x3b0 [cifs]
[ 8066.332255]  [<ffffffff9c2a3c98>] __fput+0xf8/0x210
[ 8066.332256]  [<ffffffff9c2a3dee>] ____fput+0xe/0x10
[ 8066.332258]  [<ffffffff9c0d44e5>] task_work_run+0x85/0xc0
[ 8066.332260]  [<ffffffff9c00333c>] exit_to_usermode_loop+0xcc/0xd0
[ 8066.332261]  [<ffffffff9c003e1f>] syscall_return_slowpath+0xbf/0x130
[ 8066.332263]  [<ffffffff9c8f6d98>] entry_SYSCALL_64_fastpath+0xbb/0xbd

Comment 1 Andrey 2017-01-27 04:45:04 UTC
I'm getting the same warning and the same call trace on vanilla upstream kernel 4.9.5.

As far as I remember, this happened several times soon or right after mounting a CIFS share and creating several small text files on it.

Comment 2 Justin M. Forbes 2017-04-11 15:01:51 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There are a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 24 kernel bugs.

Fedora 25 has now been rebased to 4.10.9-100.fc24.  Please test this kernel update (or newer) and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you have moved on to Fedora 26, and are still experiencing this issue, please change the version to Fedora 26.

If you experience different issues, please open a new bug report for those.

Comment 3 Andrey 2017-04-27 19:26:16 UTC
I'm not using Fedora, but was using vanilla 4.9.5 kernel before.
I've updated to 4.10.11 kernel now.

Looks like, the problem is gone.
(I haven't seen the warning for several days by now although it was easily reproducible before)

I guess the following upstream commit fixed it:

commit 81ddd8c0c5e1cb41184d66567140cb48c53eb3d1
Author:     Rabin Vincent <rabinv>
AuthorDate: Fri Jan 13 15:00:16 2017 +0100
Commit:     Steve French <smfrench>
CommitDate: Sat Jan 14 14:58:29 2017 -0600

    cifs: initialize file_info_lock

    Reviewed-by: Jeff Layton <jlayton>
    CC: Stable <stable.org>

    file_info_lock is not initalized in initiate_cifs_search(), leading to the
    following splat after a simple "mount.cifs ... dir && ls dir/":

     BUG: spinlock bad magic on CPU#0, ls/486
      lock: 0xffff880009301110, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
     CPU: 0 PID: 486 Comm: ls Not tainted 4.9.0 #27
     Hardware name: QEMU Standard PC (i440FX + PIIX, 1996)
      ffffc900042f3db0 ffffffff81327533 0000000000000000 ffff880009301110
      ffffc900042f3dd0 ffffffff810baf75 ffff880009301110 ffffffff817ae077
      ffffc900042f3df0 ffffffff810baff6 ffff880009301110 ffff880008d69900
     Call Trace:
      [<ffffffff81327533>] dump_stack+0x65/0x92
      [<ffffffff810baf75>] spin_dump+0x85/0xe0
      [<ffffffff810baff6>] spin_bug+0x26/0x30
      [<ffffffff810bb159>] do_raw_spin_lock+0xe9/0x130
      [<ffffffff8159ad2f>] _raw_spin_lock+0x1f/0x30
      [<ffffffff8127e50d>] cifs_closedir+0x4d/0x100
      [<ffffffff81181cfd>] __fput+0x5d/0x160
      [<ffffffff81181e3e>] ____fput+0xe/0x10
      [<ffffffff8109410e>] task_work_run+0x7e/0xa0
      [<ffffffff81002512>] exit_to_usermode_loop+0x92/0xa0
      [<ffffffff810026f9>] syscall_return_slowpath+0x49/0x50
      [<ffffffff8159b484>] entry_SYSCALL_64_fastpath+0xa7/0xa9

    Fixes: 3afca265b5f53a0 ("Clarify locking of cifs file and tcon structures and make more granular")
    Signed-off-by: Rabin Vincent <rabinv>
    Signed-off-by: Steve French <smfrench>

Comment 4 Fedora End Of Life 2017-07-25 23:57:49 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2017-08-08 19:19:31 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.