Bug 1397409

Summary: [Text] The 3.6 engine backup tool should point users at the upgrade helper
Product: Red Hat Enterprise Virtualization Manager Reporter: Yaniv Lavi <ylavi>
Component: ovirt-engineAssignee: Yedidyah Bar David <didi>
Status: CLOSED DUPLICATE QA Contact: Nikolai Sednev <nsednev>
Severity: medium Docs Contact:
Priority: high    
Version: 3.6.9CC: didi, gklein, irosenzw, lsurette, mavital, nsednev, rbalakri, Rhev-m-bugs, sbonazzo, srevivo, ykaul, ylavi
Target Milestone: ovirt-3.6.10Keywords: Triaged, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1370041
: 1398374 (view as bug list) Environment:
Last Closed: 2017-01-05 14:42:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1398374    
Bug Blocks:    

Comment 2 Yedidyah Bar David 2016-11-22 15:15:55 UTC
I think close notabug. Also, should really all users of engine-backup be notified about upgrades? You know, they might use it for simple backups...

We discussed adding a flag such as "--for-migration" or something like that. We can do that, but people will normally not know they should use it.

Comment 3 Yaniv Lavi 2016-11-23 08:51:30 UTC
(In reply to Yedidyah Bar David from comment #2)
> I think close notabug. Also, should really all users of engine-backup be
> notified about upgrades? You know, they might use it for simple backups...
> 
> We discussed adding a flag such as "--for-migration" or something like that.
> We can do that, but people will normally not know they should use it.

3.6 is a special use case since the user might use it for update.
We should make the text sound optional, some thing like:
"If you are backing up the engine as part of a migration to 4.0, please refer to upgrade helper <link>"  

We are getting a lot of issues in later stages of the migration, because people don't get to the helper until late in the migration.

Comment 4 Yedidyah Bar David 2016-11-23 09:16:54 UTC
(In reply to Yaniv Dary from comment #3)
> (In reply to Yedidyah Bar David from comment #2)
> > I think close notabug. Also, should really all users of engine-backup be
> > notified about upgrades? You know, they might use it for simple backups...
> > 
> > We discussed adding a flag such as "--for-migration" or something like that.
> > We can do that, but people will normally not know they should use it.
> 
> 3.6 is a special use case since the user might use it for update.
> We should make the text sound optional, some thing like:
> "If you are backing up the engine as part of a migration to 4.0, please
> refer to upgrade helper <link>"  

This means to have a downstream-only patch for engine-backup.

> 
> We are getting a lot of issues in later stages of the migration, because
> people don't get to the helper until late in the migration.

With what flow?

This bug is cloned from bug 1370041, which is about hosted-engine. You probably refer to the standalone case. Ok, fine with me then.

Sandro, please ack. If [1] was in 3.6, we could have this as a hook instead of a downstream-only patch...

[1] https://gerrit.ovirt.org/54878

Comment 5 Sandro Bonazzola 2016-11-23 14:39:47 UTC
(In reply to Yedidyah Bar David from comment #4)

> Sandro, please ack.

Acked

> If [1] was in 3.6, we could have this as a hook instead
> of a downstream-only patch...
> 
> [1] https://gerrit.ovirt.org/54878

Let's backport

Comment 7 Nikolai Sednev 2017-01-04 20:49:54 UTC
Moving this bug to verified forth to https://bugzilla.redhat.com/show_bug.cgi?id=1398374#c15.

Comment 8 Yaniv Lavi 2017-01-05 10:33:04 UTC
Is this a dup of BZ #1398374?

Comment 9 Yedidyah Bar David 2017-01-05 13:50:01 UTC
(In reply to Yaniv Dary from comment #8)
> Is this a dup of BZ #1398374?

Currently it is. Originally bug 1398374 was on the branding package. Since both bugs have merged patches we decided to not close as duplicate. If you decide to close, please copy the links to the patches.

Comment 10 Yaniv Lavi 2017-01-05 14:42:14 UTC

*** This bug has been marked as a duplicate of bug 1398374 ***