Bug 1397454

Delete router succeeded via CLI

Oddly I can't reproduce this on master, but I can't find the commit that would have fixed it for euwe.  I'll ask around to see if anyone has any ideas.

Reproduced to me too.

1. If the router has no interface, it successfully deleted
2. I failed to delete router which has interfaces connected. 
   Router does not delete, no indication to user that action failed


------------------      evm.log      ------------------

[----] I, [2016-11-27T07:46:23.532453 #13733:73f12c]  INFO -- : MIQ(MiqQueue#delivered) Message id: [888000000110049], State: [ok], Delivered in [0.021831025] seconds
[----] E, [2016-11-27T07:46:24.028092 #13752:73f12c] ERROR -- : <Fog> excon.error     #<Excon::Error::Conflict: Expected(204) <=> Actual(409 Conflict)
excon.error.response
  :body          => "{\"NeutronError\": {\"message\": \"Router de56cc7e-e323-4053-81ca-5beb3a54eb66 still has ports\", \"type\": \"RouterInUse\", \"detail\": \"\"}}"
  :cookies       => [
  ]
  :headers       => {
    "Content-Length"         => "129"
    "Content-Type"           => "application/json; charset=UTF-8"
    "Date"                   => "Sun, 27 Nov 2016 12:46:28 GMT"
    "X-Openstack-Request-Id" => "req-3d9dc806-d240-468c-8b47-470a8c4c92e2"
  }
  :host          => "10.0.0.101"
  :local_address => "10.0.0.63"
  :local_port    => 39592
  :path          => "/v2.0/routers/de56cc7e-e323-4053-81ca-5beb3a54eb66"
  :port          => 9696
  :reason_phrase => "Conflict"
  :remote_ip     => "10.0.0.101"
  :status        => 409
  :status_line   => "HTTP/1.1 409 Conflict\r\n"
>

[----] E, [2016-11-27T07:46:24.028622 #13752:73f12c] ERROR -- : MIQ(ManageIQ::Providers::Openstack::NetworkManager::NetworkRouter#delete_network_router) router=[Router_test_4c], error: Expected(204) <=> Actual(409 Conflict)
excon.error.response
  :body          => "{\"NeutronError\": {\"message\": \"Router de56cc7e-e323-4053-81ca-5beb3a54eb66 still has ports\", \"type\": \"RouterInUse\", \"detail\": \"\"}}"
  :cookies       => [
  ]
  :headers       => {
    "Content-Length"         => "129"
    "Content-Type"           => "application/json; charset=UTF-8"
    "Date"                   => "Sun, 27 Nov 2016 12:46:28 GMT"
    "X-Openstack-Request-Id" => "req-3d9dc806-d240-468c-8b47-470a8c4c92e2"
  }
  :host          => "10.0.0.101"
  :local_address => "10.0.0.63"
  :local_port    => 39592
  :path          => "/v2.0/routers/de56cc7e-e323-4053-81ca-5beb3a54eb66"
  :port          => 9696
  :reason_phrase => "Conflict"
  :remote_ip     => "10.0.0.101"
  :status        => 409
  :status_line   => "HTTP/1.1 409 Conflict\r\n"

[----] E, [2016-11-27T07:46:24.028887 #13752:73f12c] ERROR -- : MIQ(MiqQueue#deliver) Message id: [888000000110048], Error: [Expected(204) <=> Actual(409 Conflict)
excon.error.response
  :body          => "{\"NeutronError\": {\"message\": \"Router de56cc7e-e323-4053-81ca-5beb3a54eb66 still has ports\", \"type\": \"RouterInUse\", \"detail\": \"\"}}"
  :cookies       => [
  ]
  :headers       => {
    "Content-Length"         => "129"
    "Content-Type"           => "application/json; charset=UTF-8"
    "Date"                   => "Sun, 27 Nov 2016 12:46:28 GMT"
    "X-Openstack-Request-Id" => "req-3d9dc806-d240-468c-8b47-470a8c4c92e2"
  }
  :host          => "10.0.0.101"
  :local_address => "10.0.0.63"
  :local_port    => 39592
  :path          => "/v2.0/routers/de56cc7e-e323-4053-81ca-5beb3a54eb66"
  :port          => 9696
  :reason_phrase => "Conflict"
  :remote_ip     => "10.0.0.101"
  :status        => 409
  :status_line   => "HTTP/1.1 409 Conflict\r\n"
]
[----] I, [2016-11-27T07:46:24.028995 #13752:73f12c]  INFO -- : MIQ(MiqQueue#delivered) Message id: [888000000110048], State: [error], Delivered in [0.615147985] seconds
[----] I, [2016-11-27T07:46:24.031289 #13752:73f12c]  INFO -- : MIQ(MiqQueue#m_callback) Message id: [888000000110048], Invoking Callback with args: ["Finished", "error", "Expected(204) <=> Actual(409 Conflict)\nexcon.error.response\n  :body          => \"{\\\"NeutronError\\\": {\\\"message\\\": \\\"Router de56cc7e-e323-4053-81ca-5beb3a54eb66 still has ports\\\", \\\"type\\\": \\\"RouterInUse\\\", \\\"detail\\\": \\\"\\\"}}\"\n  :cookies       => [\n  ]\n  :headers       => {\n    \"Content-Length\"         => \"129\"\n    \"Content-Type\"           => \"application/json; charset=UTF-8\"\n    \"Date\"                   => \"Sun, 27 Nov 2016 12:46:28 GMT\"\n    \"X-Openstack-Request-Id\" => \"req-3d9dc806-d240-468c-8b47-470a8c4c92e2\"\n  }\n  :host          => \"10.0.0.101\"\n  :local_address => \"10.0.0.63\"\n  :local_port    => 39592\n  :path          => \"/v2.0/routers/de56cc7e-e323-4053-81ca-5beb3a54eb66\"\n  :port          => 9696\n  :reason_phrase => \"Conflict\"\n  :remote_ip     => \"10.0.0.101\"\n  :status        => 409\n  :status_line   => \"HTTP/1.1 409 Conflict\\r\\n\"\n", "nil"]
[----] I, [2016-11-27T07:46:24.031930 #13752:73f12c]  INFO -- : MIQ(MiqTask#update_status) Task: [888000000000563] [Finished] [Error] [Expected(204) <=> Actual(409 Conflict)
excon.error.response
  :body          => "{\"NeutronError\": {\"message\": \"Router de56cc7e-e323-4053-81ca-5beb3a54eb66 still has ports\", \"type\": \"RouterInUse\", \"detail\": \"\"}}"
  :cookies       => [
  ]
  :headers       => {
    "Content-Length"         => "129"
    "Content-Type"           => "application/json; charset=UTF-8"
    "Date"                   => "Sun, 27 Nov 2016 12:46:28 GMT"
    "X-Openstack-Request-Id" => "req-3d9dc806-d240-468c-8b47-470a8c4c92e2"
  }
  :host          => "10.0.0.101"
  :local_address => "10.0.0.63"
  :local_port    => 39592
  :path          => "/v2.0/routers/de56cc7e-e323-4053-81ca-5beb3a54eb66"
  :port          => 9696
  :reason_phrase => "Conflict"
  :remote_ip     => "10.0.0.101"
  :status        => 409
  :status_line   => "HTTP/1.1 409 Conflict\r\n"
]
[----] I, [2016-11-27T07:46:25.652306 #14693:918c64]  INFO -- : Querying Openstack Ceilometer for events newer than 2016-11-27T12:46:05.013000...
[----] I, [2016-11-27T07:46:25.898358 #14670:9186d8]  INFO -- : Querying Openstack Ceilometer for events newer than 2016-11-27T12:46:05.013000...

Per comment#3 I confirm this isn't an issue on euwe branch. Please re-sync with euwe. BTW I'm not sure either which commit fix-it, but again it works on euwe HEAD therefore this one an issue any more and this one can be closed.

Per comment#4, not being able to delete the router because of other dependencies is effectively expected. With latest Euwe branch, no error message is returned as the flash message indicates: 
"Delete initiated for 1 Network Router."

This doesn't mean the router was deleted but only means the deletion is scheduled.
I'm not trying to play with words here, but this is happening because of the nature of the network provider backend for Openstack. 

To avoid this kind of behaviour, more checks need to be done before triggering the delete operation.

Meanwhile this is a different issue, I suggest to open an enhancement BZ.

I was able to delete router in 5.7.0.14

verified on 5.8.0.3