Bug 1397489

Summary:	Engine does not check for input validity in external network subnet window
Product:	[oVirt] ovirt-engine	Reporter:	Mor <mkalfon>
Component:	BLL.Network	Assignee:	Dan Kenigsberg <danken>
Status:	CLOSED DEFERRED	QA Contact:	Meni Yakove <myakove>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	future	CC:	bugs, ylavi
Target Milestone:	---	Flags:	mkalfon: planning_ack? mkalfon: devel_ack? mkalfon: testing_ack?
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-23 09:37:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Mor 2016-11-22 16:04:00 UTC

Description of problem:
In the subnet creation window, "Name" and "Gateway" fields are not being checked for input validity.

Version-Release number of selected component (if applicable):
oVirt engine: 4.1.0-0.0.master.20161120231325.gitba51756.el7.centos

How reproducible:
100%

Steps to Reproduce:
1. Create new OVN network and select the subnet tab.
2. In the name input field, try to type a very long string.
3. In the gateway input field, try to type invalid IP address: 254.254.254.254. 

Actual results:
Engine accepts invalid user input.

Expected results:
Engine should verify that the gateway is a valid IP address (e.g. by using regex), and name field should be restricted according to OVS.


Additional info:

Comment 1 Yaniv Lavi 2016-11-23 09:37:06 UTC

We will be fixing this when we create a UI from the OVN provider. This will mean removing the current UI for this. Closing for now.