Bug 1397506

Summary: glfs_free() is missing from the header file and prevents nfs-ganesha-2.4 from building
Product: [Community] GlusterFS Reporter: Niels de Vos <ndevos>
Component: libgfapiAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact: Sudhir D <sdharane>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.9CC: bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.9.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-08 10:19:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1378948    
Bug Blocks:    

Description Niels de Vos 2016-11-22 16:30:18 UTC
Description of problem:
Bug 1378948 adds the functions in libgfapi to release the allocated upcall structures correctly. Unfortunately http://review.gluster.org/15653 was missed in the backport to release-3.9

Version-Release number of selected component (if applicable):
3.9

Comment 1 Worker Ant 2016-11-22 16:32:41 UTC
REVIEW: http://review.gluster.org/15907 (gfapi: add glfs_free() to glfs.h) posted (#1) for review on release-3.9 by Niels de Vos (ndevos)

Comment 2 Worker Ant 2016-11-23 02:04:00 UTC
COMMIT: http://review.gluster.org/15907 committed in release-3.9 by Kaleb KEITHLEY (kkeithle) 
------
commit 76f5061e1fe3c4602ab4f2c935c061a96e60825c
Author: Niels de Vos <ndevos>
Date:   Mon Oct 17 11:58:30 2016 +0200

    gfapi: add glfs_free() to glfs.h
    
    Commit 4721188a154acd9a0a4c096d8d73e97f3bf1b2a9 introduces glfs_free()
    but missed adding the function to the header. The symbol is correctly
    available in the library though. Testcases do not seem to fail when a
    function is missing for the headers...
    
    The glusterfs-3.7.16 packages have been released with the missing
    declaration in the header and symbol-maps. Still, the function is
    available for applications:
    
        $ objdump -T usr/lib64/libgfapi.so.0 | grep -w glfs_free
        0000000000006aa0 g    DF .text	0000000000000035  GFAPI_3.7.16 glfs_free
    
    Cherry picked from commit 5ab0b43ce67d8d131242542a80b6aa6b129ed5ee:
    > Change-Id: Ia707ee957f090dbfca028192fcc81a83dfdf4ae0
    > BUG: 1344714
    > Reported-by: Jiffin Tony Thottan <jthottan>
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/15653
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: jiffin tony Thottan <jthottan>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    
    Change-Id: Ia707ee957f090dbfca028192fcc81a83dfdf4ae0
    BUG: 1397506
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/15907
    Reviewed-by: soumya k <skoduri>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Kaushal 2017-03-08 10:19:16 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/