Bug 1397570

Summary:	Customising roles overwrites unrelated parameters, causing deployments to fail
Product:	Red Hat OpenStack	Reporter:	Julie Pichon <jpichon>
Component:	openstack-tripleo-heat-templates	Assignee:	Julie Pichon <jpichon>
Status:	CLOSED ERRATA	QA Contact:	Ola Pavlenko <opavlenk>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	10.0 (Newton)	CC:	apannu, jjoyce, jschluet, mburns, rhel-osp-director-maint, slinaber, tvignaud, ukalifon
Target Milestone:	ga	Keywords:	Triaged
Target Release:	10.0 (Newton)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-5.1.0-6.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-12-14 16:34:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Julie Pichon 2016-11-22 20:34:03 UTC

Description of problem:
Issues such as bug 1395810 means the user has to go update parameters for the different roles. This causes an extra parameter (CloudDomain) to be silently modified and saved to an empty string, causing FQDN to become unresolvable and leading every deployment to fail on galera/mariadb related errors.

Version-Release number of selected component (if applicable):
openstack-tripleo-ui-1.0.4-4.el7ost

How reproducible:
100%

Steps to Reproduce:
1. Click on the pencil for editing a role, e.g. Compute
2. Change any parameter (e.g. OvercloudComputeFlavor: compute), save the changes

Actual results:
3. The mistral environment shows another parameter was updated in addition to OvercloudComputeFlavor: 
CloudDomain:""

Expected results:
3. Only the parameters changed by the user are updated

Additional info:
This is happening because the default in the tripleo-heat-templates are not set per role, but only once in overcloud.j2.yaml where the UI cannot get at (see comments on upstream bugs for further information).

Workaround:
Make sure to manually set CloudDomain to the default indicated in the doc string - localdomain - before hitting Save.

Comment 1 Julie Pichon 2016-11-23 17:22:34 UTC

Fix landed on master, backport proposed.

Comment 2 Julie Pichon 2016-11-23 18:05:07 UTC

The fix is located in tripleo-heat-templates so, moving the bug. (The verification will likely still need to be done using the UI though.)

Comment 5 Udi Kalifon 2016-12-08 09:26:26 UTC

Verified in:
openstack-tripleo-ui-1.0.5-2.el7ost.noarch
openstack-tripleo-common-5.4.0-3.el7ost.noarch
openstack-tripleo-heat-templates-5.1.0-7.el7ost.noarch

Comment 7 errata-xmlrpc 2016-12-14 16:34:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2948.html