Bug 1397705

Summary:	PEER_REJECT, EVENT_BRICKPATH_RESOLVE_FAILED, EVENT_COMPARE_FRIEND_VOLUME_FAILED are not seen
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1397424	Environment:
Last Closed:	2017-03-08 10:19:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1397424
Bug Blocks:	1397430

Description Atin Mukherjee 2016-11-23 08:45:26 UTC

+++ This bug was initially created as a clone of Bug #1397424 +++

Description of problem:

1. PEER_REJECT event is not seen if the peer add request is from an unknown peer
during peer handshaking.
2. EVENT_COMPARE_FRIEND_VOLUME_FAILED is not seen if there is a checksum mismatch in friend volume
3. EVENT_BRICKPATH_RESOLVE_FAILED event is not seen if glusterd fails to restore bricks and fails to come up.
4. Remove EVENT_BRICKS_START_FAILED event as we already have EVENT_BRICK_START_FAILED

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-11-22 08:53:34 EST ---

REVIEW: http://review.gluster.org/15903 (glusterd: fix few events generation) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2016-11-23 03:45:02 EST ---

COMMIT: http://review.gluster.org/15903 committed in master by Atin Mukherjee (amukherj) 
------
commit 63a4f5da0feb19e47d16aa2d6aa78efaef1c93ca
Author: Atin Mukherjee <amukherj>
Date:   Tue Nov 22 19:04:54 2016 +0530

    glusterd: fix few events generation
    
    This patch does the following:
    1. Generate PEER_REJECT event if the peer add request is from an unknown peer
    during peer handshaking.
    2. EVENT_COMPARE_FRIEND_VOLUME_FAILED should be generated based on status code,
    not ret.
    3. Add EVENT_BRICKPATH_RESOLVE_FAILED event in case glusterd fails to resolve
    bricks, this is mainly at restore path.
    4. Remove EVENT_BRICKS_START_FAILED event as we already have
    EVENT_BRICK_START_FAILED
    
    Change-Id: I90e5bc4a331166d0bb3554eb2ec9df2526837a1d
    BUG: 1397424
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/15903
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Samikshan Bairagya <samikshan>

Comment 1 Worker Ant 2016-11-23 08:46:01 UTC

REVIEW: http://review.gluster.org/15912 (glusterd: fix few events generation) posted (#1) for review on release-3.9 by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2016-11-23 12:51:09 UTC

COMMIT: http://review.gluster.org/15912 committed in release-3.9 by Atin Mukherjee (amukherj) 
------
commit 4c371c2ecd432c9d6d60492bc469cf52c9bc4a96
Author: Atin Mukherjee <amukherj>
Date:   Tue Nov 22 19:04:54 2016 +0530

    glusterd: fix few events generation
    
    This patch does the following:
    1. Generate PEER_REJECT event if the peer add request is from an unknown peer
    during peer handshaking.
    2. EVENT_COMPARE_FRIEND_VOLUME_FAILED should be generated based on status code,
    not ret.
    3. Add EVENT_BRICKPATH_RESOLVE_FAILED event in case glusterd fails to resolve
    bricks, this is mainly at restore path.
    4. Remove EVENT_BRICKS_START_FAILED event as we already have
    EVENT_BRICK_START_FAILED
    
    >Reviewed-on: http://review.gluster.org/15903
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Samikshan Bairagya <samikshan>
    
    Change-Id: I90e5bc4a331166d0bb3554eb2ec9df2526837a1d
    BUG: 1397705
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/15912
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Samikshan Bairagya <samikshan>

Comment 3 Kaushal 2017-03-08 10:19:16 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/