Bug 1397778 (qt5-qtgamepad)

Summary:	Review Request: qt5-qtgamepad - Qt5 - Gamepad component
Product:	[Fedora] Fedora	Reporter:	Helio Chissini de Castro <helio>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-24 16:25:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	928937

Description Helio Chissini de Castro 2016-11-23 10:48:58 UTC

Spec URL: https://heliocastro.fedorapeople.org/qt5-qtgamepad/qt5-qtgamepad.spec
SRPM URL: https://heliocastro.fedorapeople.org/qt5-qtgamepad/qt5-qtgamepad-5.7.1-1.fc25.src.rpm
Description: Qt Gamepad provides a way to display web content in a QML application without necessarily including a full web browser stack by using native APIs where it makes sense.
Fedora Account System Username: heliocastro

Comment 1 Rex Dieter 2016-11-23 14:22:51 UTC

naming: ok

license: ok

sources: ok (for now, 5.7.1 tarballs not officially released yet)

macros: ok

scriptlets: ok

follows style/conventions of other qt5- packages

1.  dir
%{_qt5_plugindir}/gamepads/
is unowned, I'd suggest changing 
%{_qt5_plugindir}/gamepads/libevdevgamepad.so
to
%{_qt5_plugindir}/gamepads/
in %%files list


Same comments as some other qt5- related reviews,

2.  MUST reivew (and remove if needed) hard qt5 versioned dep,
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}



APPROVED

Comment 2 Rex Dieter 2017-01-24 16:25:08 UTC

confirmed imported