Bug 1398522

Summary: [abrt] realmd: __netlink_assert_response(): realmd killed by SIGABRT
Product: [Fedora] Fedora Reporter: Abhay <abhaykadam88>
Component: realmdAssignee: Sumit Bose <sbose>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: abhaykadam88, fweimer, jhrozek, sbose, stefw
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/362bb06c50b8b55ac26712eb870fd238a85ebb49
Whiteboard: abrt_hash:39d62981e3657eac338e6c64bedf9c68b2930bab;VARIANT_ID=workstation;
Fixed In Version: realmd-0.16.2-6.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-05 21:43:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: environ
none
File: limits
none
File: maps
none
File: mountinfo
none
File: namespaces
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages
none
[PATCH] LDAP: don't close LDAP socket twice stefw: review+, sbose: review+

Description Abhay 2016-11-25 05:36:03 UTC 
Version-Release number of selected component:
realmd-0.16.2-5.fc25

Additional info:
reporter:       libreport-2.8.0
backtrace_rating: 4
cmdline:        /usr/lib/realmd/realmd
crash_function: __netlink_assert_response
executable:     /usr/lib/realmd/realmd
global_pid:     1630
kernel:         4.8.6-300.fc25.x86_64
pkg_fingerprint: 4089 D8F2 FDB1 9C98
pkg_vendor:     Fedora Project
runlevel:       N 5
type:           CCpp
uid:            0

Truncated backtrace:
Thread no. 1 (7 frames)
 #4 __netlink_assert_response at ../sysdeps/unix/sysv/linux/netlink_assert_response.c:103
 #5 make_request at ../sysdeps/unix/sysv/linux/check_pf.c:171
 #6 __check_pf at ../sysdeps/unix/sysv/linux/check_pf.c:329
 #7 getaddrinfo at ../sysdeps/posix/getaddrinfo.c:2338
 #8 do_lookup_by_name at gthreadedresolver.c:79
 #9 g_task_thread_pool_thread at gtask.c:1304
 #11 g_thread_proxy at gthread.c:784
Comment 1 Abhay 2016-11-25 05:36:09 UTC 
Created attachment 1224121 [details]
File: backtrace
Comment 2 Abhay 2016-11-25 05:36:11 UTC 
Created attachment 1224122 [details]
File: cgroup
Comment 3 Abhay 2016-11-25 05:36:12 UTC 
Created attachment 1224123 [details]
File: core_backtrace
Comment 4 Abhay 2016-11-25 05:36:14 UTC 
Created attachment 1224124 [details]
File: dso_list
Comment 5 Abhay 2016-11-25 05:36:16 UTC 
Created attachment 1224125 [details]
File: environ
Comment 6 Abhay 2016-11-25 05:36:17 UTC 
Created attachment 1224126 [details]
File: limits
Comment 7 Abhay 2016-11-25 05:36:20 UTC 
Created attachment 1224127 [details]
File: maps
Comment 8 Abhay 2016-11-25 05:36:22 UTC 
Created attachment 1224128 [details]
File: mountinfo
Comment 9 Abhay 2016-11-25 05:36:24 UTC 
Created attachment 1224129 [details]
File: namespaces
Comment 10 Abhay 2016-11-25 05:36:25 UTC 
Created attachment 1224130 [details]
File: open_fds
Comment 11 Abhay 2016-11-25 05:36:27 UTC 
Created attachment 1224131 [details]
File: proc_pid_status
Comment 12 Abhay 2016-11-25 05:36:28 UTC 
Created attachment 1224132 [details]
File: var_log_messages
Comment 13 Florian Weimer 2016-11-25 11:55:48 UTC 
This glibc assert intends to catch cases where the internal file descriptor used for Netlink processing has been closed by another thread.  EBADF suggests that this has happened here.

This could have been caused by a race internal to glibc, but we have not seen this yet anywhere since we added the assert, so I suspect it's an application bug.
Comment 14 Sumit Bose 2016-11-28 14:43:22 UTC 
Can you reproduce the issue reliable? I was able to reproduce it by chance and created a test build at https://koji.fedoraproject.org/koji/taskinfo?taskID=16657441 . Can you check if it fixes the issue for you?
Comment 15 Sumit Bose 2016-11-29 12:47:17 UTC 
Created attachment 1225807 [details]
[PATCH] LDAP: don't close LDAP socket twice

Hi Stef,

can you check the attached patch? I wonder what was the original motivation to call close() before ldap_destroy(). Did you had any issues with a blocking ldap_destroy()?
Comment 16 Stef Walter 2016-11-29 13:06:23 UTC 
Comment on attachment 1225807 [details]
[PATCH] LDAP: don't close LDAP socket twice

Can ldap_destroy() block when the LDAP server is no longer reachable? Once that question is answered, the patch looks good to me.
Comment 17 Sumit Bose 2016-11-29 13:59:54 UTC 
I did some basic test calling ldap_initialize(), ldap_search_ext() and ldap_destroy(). Before calling ldap_destroy() I either paused the VM running the LDAP server or killed the LDAP server process in the VM. In both cases ldap_destroy() didn't block.
Comment 18 Stef Walter 2016-11-29 15:33:50 UTC 
Patch merged into realmd git master.
Comment 19 Fedora Update System 2016-12-01 17:12:58 UTC 
realmd-0.16.2-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b06e7168c9
Comment 20 Fedora Update System 2016-12-03 04:35:23 UTC 
realmd-0.16.2-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b06e7168c9
Comment 21 Fedora Update System 2016-12-05 21:43:52 UTC 
realmd-0.16.2-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.