| Summary: | VAPI bindings generated with vala 0.34.x can contain errors | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | vala | Assignee: | Michel Alexandre Salim <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 25 | CC: | fabian.deutsch, klember, michel, projects.rg, thaller, zeeshanak |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | vala-0.34.3-2.fc25 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-05 21:44:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Thanks, I've backported that patch to vala-0.34.3-2.fc25 vala-0.34.3-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-54ecb08413 I can confirm that rebuilding NetworkManager with the patched vala version results in the correct info being in the .vapi file. Thanks for the quick fix, now I guess that a package rebuild for NetworkManager has to be triggered as well for the change to get into the f25 (and f26?) repos? Great, thanks for checking! The fixed vala versions should be in the build roots for both f25 and f26 so it should just be a straightforward rebuild for NetworkManager. vala-0.34.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-54ecb08413 vala-0.34.3-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. NetworkManager also rebuild: NetworkManager-1.4.2-2.fc25 http://koji.fedoraproject.org/koji/buildinfo?buildID=823289 NetworkManager-1.5.2-4.fc26 http://koji.fedoraproject.org/koji/buildinfo?buildID=823290 and a f25 update: https://bodhi.fedoraproject.org/updates/NetworkManager-1.4.2-2.fc25 |
The vapi bindings generated during the build of other packages might contain errors if they were built / rebuilt since vala has been updated to 0.34.x: Fixed-size arrays are not properly recognized as return types (anymore?), and sousing the "offending" functions obviously results in type mismatches. For example, the public uint8 get_address () function in NM.IP6Address (part of libnm-util) should have a return type of "uint8[]" instead of "uint8" from what I have been able to determine during "troubleshooting" with ricotz. See commit https://git.gnome.org/browse/vala/commit/?h=0.34&id=7e76f75e42e7ac45c896e81e97955c8b2089d7e9 in the vala git for more info (the FIXME he added after our discussion). Every vala release from the 0.34 branch has this error, and the newly released vala 0.34.3 doesn't fix the problem yet. Every package that generates .vapi files (and exposes functions with a fixed-length array return type) will have to be rebuilt after a fix for this is available.